Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 1486153002: Revert of Make NVPR a GL context option instead of a GL context (Closed)

Created:
5 years ago by bsalomon
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@commandbuffer-as-api-02-other-tests-refactor
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make NVPR a GL context option instead of a GL context (patchset #2 id:20001 of https://codereview.chromium.org/1448883002/ ) Reason for revert: BUG=skia:4609 skbug.com/4609 Seems like GrContextFactory needs to fail when the NVPR option is requested but the driver version isn't sufficiently high. Original issue's description: > Make NVPR a GL context option instead of a GL context > > Make NVPR a GL context option instead of a GL context. > This may enable NVPR to be run with command buffer > interface. > > No functionality change in DM or nanobench. NVPR can > only be run with normal GL APIs. > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/eeebdb538d476c1bfc8b63a946094ca1b505ecd1 TBR=mtklein@google.com,jvanverth@google.com,kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/a0a024e323ebf73ea4559d4b29f937902703828b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -864 lines) Patch
M bench/nanobench.h View 1 chunk +0 lines, -2 lines 0 comments Download
M bench/nanobench.cpp View 6 chunks +24 lines, -35 lines 0 comments Download
M dm/DM.cpp View 3 chunks +3 lines, -9 lines 0 comments Download
M dm/DMGpuSupport.h View 3 chunks +1 line, -7 lines 0 comments Download
M dm/DMSrcSink.h View 1 chunk +6 lines, -10 lines 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +10 lines, -24 lines 0 comments Download
M src/gpu/GrContextFactory.h View 4 chunks +23 lines, -22 lines 0 comments Download
M src/gpu/GrContextFactory.cpp View 4 chunks +9 lines, -10 lines 0 comments Download
M tests/GLInterfaceValidationTest.cpp View 1 chunk +16 lines, -21 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 1 chunk +1 line, -17 lines 0 comments Download
D tools/PictureRenderer.h View 1 chunk +0 lines, -707 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bsalomon
Created Revert of Make NVPR a GL context option instead of a GL context
5 years ago (2015-12-01 15:58:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486153002/1
5 years ago (2015-12-01 15:58:37 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-01 15:58:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a0a024e323ebf73ea4559d4b29f937902703828b

Powered by Google App Engine
This is Rietveld 408576698