Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1486003003: [debugger] only track LiveEdit if source changes. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] only track LiveEdit if source changes. R=hablich@chromium.org Committed: https://crrev.com/986412998ca07aed2a8566e2e3a5d8d69c761869 Cr-Commit-Position: refs/heads/master@{#32450}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/runtime/runtime-liveedit.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Yang
5 years ago (2015-12-01 10:00:08 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486003003/1
5 years ago (2015-12-01 10:00:22 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/10778) v8_linux_arm64_rel on ...
5 years ago (2015-12-01 10:03:19 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486003003/20001
5 years ago (2015-12-01 10:13:31 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 10:44:48 UTC) #9
Michael Hablich
On 2015/12/01 10:44:48, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-12-01 10:54:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486003003/20001
5 years ago (2015-12-01 10:54:47 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-01 10:56:20 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-01 10:56:37 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/986412998ca07aed2a8566e2e3a5d8d69c761869
Cr-Commit-Position: refs/heads/master@{#32450}

Powered by Google App Engine
This is Rietveld 408576698