Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/runtime/runtime-liveedit.cc

Issue 1486003003: [debugger] only track LiveEdit if source changes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/debug/debug-frames.h" 9 #include "src/debug/debug-frames.h"
10 #include "src/debug/liveedit.h" 10 #include "src/debug/liveedit.h"
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 // Compares 2 strings line-by-line, then token-wise and returns diff in form 222 // Compares 2 strings line-by-line, then token-wise and returns diff in form
223 // of JSArray of triplets (pos1, pos1_end, pos2_end) describing list 223 // of JSArray of triplets (pos1, pos1_end, pos2_end) describing list
224 // of diff chunks. 224 // of diff chunks.
225 RUNTIME_FUNCTION(Runtime_LiveEditCompareStrings) { 225 RUNTIME_FUNCTION(Runtime_LiveEditCompareStrings) {
226 HandleScope scope(isolate); 226 HandleScope scope(isolate);
227 CHECK(isolate->debug()->live_edit_enabled()); 227 CHECK(isolate->debug()->live_edit_enabled());
228 DCHECK(args.length() == 2); 228 DCHECK(args.length() == 2);
229 CONVERT_ARG_HANDLE_CHECKED(String, s1, 0); 229 CONVERT_ARG_HANDLE_CHECKED(String, s1, 0);
230 CONVERT_ARG_HANDLE_CHECKED(String, s2, 1); 230 CONVERT_ARG_HANDLE_CHECKED(String, s2, 1);
231 231
232 isolate->debug()->feature_tracker()->Track(DebugFeatureTracker::kLiveEdit); 232 Handle<JSArray> result = LiveEdit::CompareStrings(s1, s2);
233 uint32_t array_length;
234 CHECK(result->length()->ToArrayLength(&array_length));
235 if (array_length > 0) {
236 isolate->debug()->feature_tracker()->Track(DebugFeatureTracker::kLiveEdit);
237 }
233 238
234 return *LiveEdit::CompareStrings(s1, s2); 239 return *result;
235 } 240 }
236 241
237 242
238 // Restarts a call frame and completely drops all frames above. 243 // Restarts a call frame and completely drops all frames above.
239 // Returns true if successful. Otherwise returns undefined or an error message. 244 // Returns true if successful. Otherwise returns undefined or an error message.
240 RUNTIME_FUNCTION(Runtime_LiveEditRestartFrame) { 245 RUNTIME_FUNCTION(Runtime_LiveEditRestartFrame) {
241 HandleScope scope(isolate); 246 HandleScope scope(isolate);
242 CHECK(isolate->debug()->live_edit_enabled()); 247 CHECK(isolate->debug()->live_edit_enabled());
243 DCHECK(args.length() == 2); 248 DCHECK(args.length() == 2);
244 CONVERT_NUMBER_CHECKED(int, break_id, Int32, args[0]); 249 CONVERT_NUMBER_CHECKED(int, break_id, Int32, args[0]);
(...skipping 16 matching lines...) Expand all
261 // We don't really care what the inlined frame index is, since we are 266 // We don't really care what the inlined frame index is, since we are
262 // throwing away the entire frame anyways. 267 // throwing away the entire frame anyways.
263 const char* error_message = LiveEdit::RestartFrame(it.frame()); 268 const char* error_message = LiveEdit::RestartFrame(it.frame());
264 if (error_message) { 269 if (error_message) {
265 return *(isolate->factory()->InternalizeUtf8String(error_message)); 270 return *(isolate->factory()->InternalizeUtf8String(error_message));
266 } 271 }
267 return heap->true_value(); 272 return heap->true_value();
268 } 273 }
269 } // namespace internal 274 } // namespace internal
270 } // namespace v8 275 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698