Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1485973004: Reduce use of GrRenderTarget in GrTextContexts (Closed)

Created:
5 years ago by robertphillips
Modified:
5 years ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reduce use of GrRenderTarget in GrTextContexts Cleanup prior to switching over to GrRenderTargetProxy. Committed: https://skia.googlesource.com/skia/+/954cbc15b39e1b45c6244f2811b5ac6be6e412fd

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/gpu/GrDrawContext.cpp View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
robertphillips
5 years ago (2015-12-01 22:16:06 UTC) #3
joshualitt
lgtm https://codereview.chromium.org/1485973004/diff/1/src/gpu/GrAtlasTextContext.cpp File src/gpu/GrAtlasTextContext.cpp (right): https://codereview.chromium.org/1485973004/diff/1/src/gpu/GrAtlasTextContext.cpp#newcode1410 src/gpu/GrAtlasTextContext.cpp:1410: SkAutoTUnref<GrTexture> texture(context->textureProvider()->createTexture(desc, true, nullptr, 0)); line wrap
5 years ago (2015-12-02 17:41:32 UTC) #5
robertphillips
PTAL - all that is left after rebasing is a bit of trying to avoid ...
5 years ago (2015-12-02 17:48:29 UTC) #6
joshualitt
On 2015/12/02 17:48:29, robertphillips wrote: > PTAL - all that is left after rebasing is ...
5 years ago (2015-12-02 17:49:29 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485973004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485973004/20001
5 years ago (2015-12-02 17:50:08 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 18:06:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485973004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485973004/20001
5 years ago (2015-12-02 18:30:26 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-02 18:33:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/954cbc15b39e1b45c6244f2811b5ac6be6e412fd

Powered by Google App Engine
This is Rietveld 408576698