[content shell] implement auto resize related WebTestDelegate interfaces

[content shell] implement auto resize related WebTestDelegate interfaces

BUG=111316
R=mkwst@chromium.org, piman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201456

[jochen (gone - plz use gerrit), 2013-05-14 09:11:00]

Antoine, please review content/renderer/*
Mike, please review the rest

[jochen (gone - plz use gerrit), 2013-05-14 09:12:44]

blink side here https://codereview.chromium.org/14776006

[Mike West, 2013-05-14 09:17:18]

On 2013/05/14 09:12:44, jochen wrote:
> blink side here https://codereview.chromium.org/14776006

I was just about to ask for this. Thanks!

This LGTM.

[piman, 2013-05-14 19:27:37]

https://codereview.chromium.org/14859017/diff/6001/content/renderer/render_wi...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/14859017/diff/6001/content/renderer/render_wi...
content/renderer/render_widget.cc:408: auto_resize_mode_ ||
paint_aggregator_.HasPendingUpdate());
This looks wrong. Why wouldn't we get an invalidation if auto_resize_mode_ is
true?

https://codereview.chromium.org/14859017/diff/6001/content/shell/renderer/web...
File content/shell/renderer/webkit_test_runner.cc (right):

https://codereview.chromium.org/14859017/diff/6001/content/shell/renderer/web...
content/shell/renderer/webkit_test_runner.cc:357:
render_view()->GetWebView()->resize(new_size);
DisableAutoResizeMode will call RenderViewImpl::OnDisableAutoResize which calls
RenderWidget::Resize which will call resize() on its webwidget (which is
RenderViewImpl's webview). Why is this needed then?

Similarly above, ForceResizeRenderView looks redundant as well....

[jochen (gone - plz use gerrit), 2013-05-21 13:49:11]

ptal

https://codereview.chromium.org/14859017/diff/6001/content/renderer/render_wi...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/14859017/diff/6001/content/renderer/render_wi...
content/renderer/render_widget.cc:408: auto_resize_mode_ ||
paint_aggregator_.HasPendingUpdate());
oh well

because I abused the didAutoResize() call. I cleaned that up and now invoke
setWindowRect() from ForceResizeRenderView. That way didAutoResize doesn't call
to Resize and we don't need this

https://codereview.chromium.org/14859017/diff/6001/content/shell/renderer/web...
File content/shell/renderer/webkit_test_runner.cc (right):

https://codereview.chromium.org/14859017/diff/6001/content/shell/renderer/web...
content/shell/renderer/webkit_test_runner.cc:357:
render_view()->GetWebView()->resize(new_size);
On 2013/05/14 19:27:37, piman wrote:
> DisableAutoResizeMode will call RenderViewImpl::OnDisableAutoResize which
calls
> RenderWidget::Resize which will call resize() on its webwidget (which is
> RenderViewImpl's webview). Why is this needed then?
> 
> Similarly above, ForceResizeRenderView looks redundant as well....
Cleaned this up as well.

I still need one ForceResizeRenderView call as OnDisableAutoResize won't set the
window rect.

[piman, 2013-05-21 22:25:09]

LGTM

[jochen (gone - plz use gerrit), 2013-05-22 07:01:49]

Committed patchset #3 manually as r201456.