Issue 14776006: Add an interface to WebTestDelegate for auto resizing

Issue 14776006: Add an interface to WebTestDelegate for auto resizing (Closed)

Created:
7 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 7 months ago

Reviewers:
Mike West

CC:
blink-reviews, jamesr, eae+blinkwatch, abarth_chromum.org, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add an interface to WebTestDelegate for auto resizing BUG=111316 R=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150301

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -5 lines)			Patch
M	Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h	View	2 chunks	+5 lines, -0 lines	2 comments	Download
M	Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	Tools/DumpRenderTree/chromium/WebViewHost.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Tools/DumpRenderTree/chromium/WebViewHost.cpp	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mike West

LGTM w/ one small question. https://codereview.chromium.org/14776006/diff/1/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h File Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (right): https://codereview.chromium.org/14776006/diff/1/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h#newcode105 Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:105: virtual void disableAutoResizeMode(const WebKit::WebSize&) ...

7 years, 7 months ago (2013-05-14 09:17:00 UTC) #2

jochen (gone - plz use gerrit)

https://codereview.chromium.org/14776006/diff/1/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h File Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (right): https://codereview.chromium.org/14776006/diff/1/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h#newcode105 Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:105: virtual void disableAutoResizeMode(const WebKit::WebSize&) { } On 2013/05/14 09:17:00, ...

7 years, 7 months ago (2013-05-14 09:17:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/14776006/1

7 years, 7 months ago (2013-05-14 09:19:53 UTC) #4

jochen (gone - plz use gerrit)

7 years, 7 months ago (2013-05-14 09:54:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r150301 (presubmit successful).

Expand Messages | Collapse Messages