Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14859016: Don't force layout for mouse event hit tests (Closed)

Created:
7 years, 7 months ago by cbiesinger
Modified:
7 years, 7 months ago
Reviewers:
ojan, jamesr, tonyg, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Don't force layout for mouse event hit tests Before the initial document layout, we shouldn't force a layout for mouse events, because they are not intended for the new document anyway - the user can't see the document yet! Just ignore those events by making the hit tests match nothing. Otherwise, the hit test would force a layout, which is undesirable because that leads to a flash of an empty document. BUG=1373 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150709

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a test and check didFirstLayout() instead of shouldScheduleLayout(). And don't force layouts wh… #

Total comments: 4

Patch Set 3 : rebased now that the eventsender change has been committed #

Patch Set 4 : fix review comments #

Patch Set 5 : switch back to shouldScheduleLayout #

Patch Set 6 : update all tests #

Total comments: 1

Patch Set 7 : add comment, fix a few more tests #

Patch Set 8 : fix review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -8 lines) Patch
M LayoutTests/editing/pasteboard/data-transfer-items.html View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/editing/selection/contenteditable-click-inside.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/editing/selection/script-tests/click-in-margins-inside-editable-div.js View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/editing/selection/script-tests/click-outside-editable-div.js View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/block/float/float-in-float-hit-testing.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-generated-content/hover-style-change.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/hover-active-drag.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/layerZOrderCrash.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/resize-corner-tracking-transformed.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/resize-corner-tracking-transformed-iframe.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/HTMLTableColElement/resize-table-using-col-width.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-xy-properties.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/replaced-image-map.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/capture-on-target.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/clientXY-in-zoom-and-scroll.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/dblclick-addEventListener.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/drop-with-file-paths.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/event-view-toString.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/frame-click-focus.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/mouse-focus-imagemap.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/mouseclick-target-and-positioning.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/mouseout-on-window.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/mouseup-outside-document.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/pointer-events.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/pointer-events-2.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/prevent-drag-to-navigate.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/related-target.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/script-tests/mouse-click-events.js View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/fast/events/script-tests/page-scaled-mouse-click.js View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/scrollbar-double-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/emulate-touch-events.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/gesture-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/gesture-dblclick.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/gesture-tap-active-state.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/updateLayoutForHitTest.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/window-events-bubble.html View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/fast/events/window-events-bubble2.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/window-events-capture.html View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/fast/events/zoom-dblclick.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/files/apply-blob-url-to-xhr.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/files/file-list-test.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/files/file-reader-abort.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/files/file-reader-event-listener.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/files/resources/setup-for-read-common.js View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/files/workers/worker-apply-blob-url-to-xhr.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/file/get-file-upload.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/input-appearance-preventDefault.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/input-text-click-inside.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/input-text-click-outside.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/input-text-double-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/input-text-drag-down.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/input-text-self-emptying-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/option-mouseevents.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/password-doubleclick-selection.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/select-empty-list.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/frames/frame-deep-nested-resize.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-1-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-10-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-2-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-3-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-4-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-5-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-6-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-7-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-8-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-add-summary-9-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-mouse-click.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-1-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-2-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-3-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-4-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-5-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/html/details-remove-summary-6-and-click.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/images/image-map-multiple.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/images/image-map-multiple-xhtml.xhtml View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/images/image-map-zoom.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/images/imagemap-case.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/images/script-tests/imagemap-dynamic-area-updates.js View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/event-while-loading.html View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/event-while-loading-expected.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/repaint/japanese-rl-selection-clear.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/replaced/image-map.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/replaced/image-map-bug16782.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/scrolling/hover-during-scroll.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/text/atsui-rtl-override-selection.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/text/international/khmer-selection.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/text/textIteratorNilRenderer.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/local/blob/script-tests/send-hybrid-blob.js View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/navigation/resources/javascriptlink.html View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/plugins/user-gesture.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/scrollbars/scrollbar-miss-mousemove-disabled.html View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/anchor-on-use.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/gradient-attr-update.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/hit-test-path.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/hit-test-path-stroke.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/hover-default-fill.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/image-clipped-hit.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-all.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-preserveAspectRatio.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-transform.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-viewBox.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-viewBox-transform.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-viewTarget.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/linking-a-03-b-zoomAndPan.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/linking-uri-01-b.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/marker-changes.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/mask-changes.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/mouse-move-on-svg-container.xhtml View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/mouse-move-on-svg-container-standalone.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/mouse-move-on-svg-root.xhtml View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/mouse-move-on-svg-root-standalone.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/pan-direction.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-image.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-image-css-transform.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-on-rounded-rect.xhtml View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/pointer-events-on-svg-with-pointer.xhtml View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/pointer-events-on-svg-without-pointer.xhtml View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/pointer-events-path.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-text.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-text-css-transform.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/polyline-hittest.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/resources/focus-event-handling.js View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/custom/stroke-width-click.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/text-hit-test.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/use-css-events.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/use-move-to-offset.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/svg/custom/viewBox-hit.svg View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/touchadjustment/block-testing.html View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/touchadjustment/context-menu.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/touchadjustment/context-menu-select-text.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/touchadjustment/context-menu-text-subtargets.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/touchadjustment/disabled-formelements.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/touchadjustment/rotated-node.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/touchadjustment/touch-inlines.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/touchadjustment/zoom-basic.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/touchadjustment/zoom-fatfinger.html View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 5 6 7 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 4 5 6 7 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
cbiesinger
7 years, 7 months ago (2013-05-13 23:58:10 UTC) #1
eseidel
Why is "shouldScheduleLayout()" the correct check?
7 years, 7 months ago (2013-05-14 00:34:39 UTC) #2
eseidel
https://codereview.chromium.org/14859016/diff/1/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/14859016/diff/1/Source/core/dom/Document.cpp#newcode2799 Source/core/dom/Document.cpp:2799: if (!renderer() || !shouldScheduleLayout()) What if I have a ...
7 years, 7 months ago (2013-05-14 00:35:03 UTC) #3
ojan
On 2013/05/14 00:35:03, Eric Seidel wrote: > https://codereview.chromium.org/14859016/diff/1/Source/core/dom/Document.cpp > File Source/core/dom/Document.cpp (right): > > https://codereview.chromium.org/14859016/diff/1/Source/core/dom/Document.cpp#newcode2799 ...
7 years, 7 months ago (2013-05-14 00:43:51 UTC) #4
cbiesinger
On 2013/05/14 00:34:39, Eric Seidel wrote: > Why is "shouldScheduleLayout()" the correct check? shouldScheduleLayout() is ...
7 years, 7 months ago (2013-05-14 00:44:40 UTC) #5
cbiesinger
https://codereview.chromium.org/14859016/diff/1/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/14859016/diff/1/Source/core/dom/Document.cpp#newcode2799 Source/core/dom/Document.cpp:2799: if (!renderer() || !shouldScheduleLayout()) On 2013/05/14 00:35:03, Eric Seidel ...
7 years, 7 months ago (2013-05-14 00:46:57 UTC) #6
cbiesinger
OK, new version uploaded. This now has a test and checks for whether we had ...
7 years, 7 months ago (2013-05-14 01:46:23 UTC) #7
ojan
https://codereview.chromium.org/14859016/diff/10001/LayoutTests/fast/repaint/event-while-loading.html File LayoutTests/fast/repaint/event-while-loading.html (right): https://codereview.chromium.org/14859016/diff/10001/LayoutTests/fast/repaint/event-while-loading.html#newcode22 LayoutTests/fast/repaint/event-while-loading.html:22: pre.innerHTML = repaintRects; I think you also meant to ...
7 years, 7 months ago (2013-05-14 01:55:22 UTC) #8
jamesr
What will a page observe if it registers a mousemove listener before the first layout? ...
7 years, 7 months ago (2013-05-14 03:03:44 UTC) #9
cbiesinger
When the page registers a mouse move (or click) handler before the first layout, it ...
7 years, 7 months ago (2013-05-14 18:09:55 UTC) #10
cbiesinger
So it turns out that 179 tests fail if I use didFirstLayout. They pass if ...
7 years, 7 months ago (2013-05-15 01:46:41 UTC) #11
ojan
I think shouldScheduleLayout is actually wrong in some cases, e.g. we'll now not fire mouse ...
7 years, 7 months ago (2013-05-15 22:11:54 UTC) #12
cbiesinger
On 2013/05/15 22:11:54, ojan wrote: > I think shouldScheduleLayout is actually wrong in some cases, ...
7 years, 7 months ago (2013-05-15 22:21:04 UTC) #13
cbiesinger
OK, uploaded a new version with the tests fixed.
7 years, 7 months ago (2013-05-18 00:26:36 UTC) #14
ojan
Please add the comments and then LGTM. https://codereview.chromium.org/14859016/diff/39001/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/14859016/diff/39001/Source/core/dom/Document.cpp#newcode2799 Source/core/dom/Document.cpp:2799: if (!renderer() ...
7 years, 7 months ago (2013-05-18 00:41:44 UTC) #15
cbiesinger
On 2013/05/18 00:41:44, ojan wrote: > Please add the comments and then LGTM. > > ...
7 years, 7 months ago (2013-05-18 01:51:37 UTC) #16
ojan
It's not obvious that renderView->hitTest is what forces the layout that the comment mentions. Other ...
7 years, 7 months ago (2013-05-18 02:07:41 UTC) #17
cbiesinger
On 2013/05/18 02:07:41, ojan wrote: > It's not obvious that renderView->hitTest is what forces the ...
7 years, 7 months ago (2013-05-18 02:53:02 UTC) #18
cbiesinger
Committed patchset #8 manually as r150709 (presubmit successful).
7 years, 7 months ago (2013-05-20 22:43:54 UTC) #19
cbiesinger
On 2013/05/20 22:43:54, cbiesinger wrote: > Committed patchset #8 manually as r150709 (presubmit successful). So, ...
7 years, 7 months ago (2013-05-21 01:11:07 UTC) #20
cbiesinger
On 2013/05/21 01:11:07, cbiesinger wrote: > On 2013/05/20 22:43:54, cbiesinger wrote: > > Committed patchset ...
7 years, 7 months ago (2013-05-21 01:52:09 UTC) #21
cbiesinger
7 years, 7 months ago (2013-05-21 02:06:14 UTC) #22
Message was sent while issue was closed. 
On 2013/05/21 01:52:09, cbiesinger wrote:
> as discussed, I'll revert EventSender to force layouts for events but add a
mode
> where it doesn't do that.

For that followup, see https://codereview.chromium.org/15425005/

Powered by Google App Engine
This is Rietveld 408576698