Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: Source/core/dom/Document.cpp

Issue 14859016: Don't force layout for mouse event hit tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix review comment Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/touchadjustment/zoom-fatfinger.html ('k') | Source/core/page/EventHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index 8950dc3b2d2647704a6ae4ac86380e3a8e6bbe47..cdb404ac9b852a2683b7b0f2ec7dcf9eef814575 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -2796,7 +2796,13 @@ MouseEventWithHitTestResults Document::prepareMouseEvent(const HitTestRequest& r
{
ASSERT(!renderer() || renderer()->isRenderView());
- if (!renderer())
+ // RenderView::hitTest causes a layout, and we don't want to hit that until the first
+ // layout because until then, there is nothing shown on the screen - the user can't
+ // have intentionally clicked on something belonging to this page. Furthermore,
+ // mousemove events before the first layout should not lead to a premature layout()
+ // happening, which could show a flash of white.
+ // See also the similar code in EventHandler::hitTestResultAtPoint.
+ if (!renderer() || !view() || !view()->didFirstLayout())
return MouseEventWithHitTestResults(event, HitTestResult(LayoutPoint()));
HitTestResult result(documentPoint);
« no previous file with comments | « LayoutTests/touchadjustment/zoom-fatfinger.html ('k') | Source/core/page/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698