Use a block cursor in overtype mode

Source/core/editing/Editor.cpp

Index: Source/core/editing/Editor.cpp
diff --git a/Source/core/editing/Editor.cpp b/Source/core/editing/Editor.cpp
index 9b088b228ddfc35b76372abff0a8ce1006fb0213..e3003dc81516e8b8489b77c7211d9cb12f4312a0 100644
--- a/Source/core/editing/Editor.cpp
+++ b/Source/core/editing/Editor.cpp
@@ -2913,4 +2913,10 @@ void Editor::applyDictationAlternativelternative(const String& alternativeString
     m_alternativeTextController->applyDictationAlternative(alternativeString);
 }
 
+void Editor::toggleOverwriteModeEnabled()
+{
+    m_overwriteModeEnabled = !m_overwriteModeEnabled;

[esprehn, 2013/06/12 19:25:30]

I'd prefer we didn't store the overwrite mode state in two places. Can you
eliminate the boolean in Editor? The isOvertypeMode() method can just return
selection()->isBlockCursor() or something.

[svillar, 2013/06/13 08:53:06]

So there is a reason for having these two states which are actually different
things. The boolean in the editor is the one used to determine how the editing
code will behave, inserting new characters or overwriting the existing ones.

We cannot directly use it in the selection to decide whether or not to paint a
block cursor because sometimes you don't want to do it even if we're in overtype
mode. This happens for example when the cursor is at the end of the line, in
that case we want to paint a caret even in overtype mode.

So the boolean in the editor will be true, instructing the code to work in
overtype mode, but the boolean in the selection will be false, and thus a caret
(and not a block cursor) will be painted.

+    frame()->selection()->setShouldShowBlockCursor(m_overwriteModeEnabled);
+};
+
 } // namespace WebCore