Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt

Issue 14859008: Use a block cursor in overtype mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/editing/selection/block-cursor-overtype-mode.html ('k') | Source/core/editing/Editor.h » ('j') | Source/core/editing/Editor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt
diff --git a/LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt b/LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt
new file mode 100644
index 0000000000000000000000000000000000000000..5beb23a786b03cfa5de91c031763b6cf902f355e
--- /dev/null
+++ b/LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt
@@ -0,0 +1,156 @@
+This test checks that the cursor covers the next character to be overwritten in overtype mode instead of being painted as a caret (1px width bar)
+
+ABC
+ABC
+שדן
+שדן
+שדןABC
+שדןABC
+Verifying block cursor position and width for each position in 'ABC' in a ltr block
+getSelection().collapse(textNode, 0)
esprehn 2013/06/12 19:25:30 It'd be nicer if these tests were broken into sepa
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 1)
+PASS blockCursorStartPosition[0] < blockCursorStartPosition[1] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 2)
+PASS blockCursorStartPosition[1] < blockCursorStartPosition[2] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 3)
+PASS blockCursor.width is 0
+PASS internals.absoluteCaretBounds().width is 1
+
+Verifying block cursor position and width for each position in 'ABC' in a rtl block
+getSelection().collapse(textNode, 0)
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 1)
+PASS blockCursorStartPosition[0] < blockCursorStartPosition[1] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 2)
+PASS blockCursorStartPosition[1] < blockCursorStartPosition[2] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 3)
+PASS blockCursor.width is 0
+PASS internals.absoluteCaretBounds().width is 1
+
+Verifying block cursor position and width for each position in 'שדן' in a ltr block
+getSelection().collapse(textNode, 0)
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 1)
+PASS blockCursorStartPosition[0] > blockCursorStartPosition[1] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 2)
+PASS blockCursorStartPosition[1] > blockCursorStartPosition[2] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 3)
+PASS blockCursor.width is 0
+PASS internals.absoluteCaretBounds().width is 1
+
+Verifying block cursor position and width for each position in 'שדן' in a rtl block
+getSelection().collapse(textNode, 0)
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 1)
+PASS blockCursorStartPosition[0] > blockCursorStartPosition[1] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 2)
+PASS blockCursorStartPosition[1] > blockCursorStartPosition[2] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 3)
+PASS blockCursor.width is 0
+PASS internals.absoluteCaretBounds().width is 1
+
+Verifying block cursor position and width for each position in 'שדןABC' in a ltr block
+getSelection().collapse(textNode, 0)
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 1)
+PASS blockCursorStartPosition[0] > blockCursorStartPosition[1] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 2)
+PASS blockCursorStartPosition[1] > blockCursorStartPosition[2] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 3)
+PASS blockCursorStartPosition[2] < blockCursorStartPosition[3] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 4)
+PASS blockCursorStartPosition[3] < blockCursorStartPosition[4] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 5)
+PASS blockCursorStartPosition[4] < blockCursorStartPosition[5] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 6)
+PASS blockCursor.width is 0
+PASS internals.absoluteCaretBounds().width is 1
+
+Verifying block cursor position and width for each position in 'שדןABC' in a rtl block
+getSelection().collapse(textNode, 0)
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 1)
+PASS blockCursorStartPosition[0] > blockCursorStartPosition[1] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 2)
+PASS blockCursorStartPosition[1] > blockCursorStartPosition[2] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 3)
+PASS blockCursorStartPosition[2] > blockCursorStartPosition[3] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 4)
+PASS blockCursorStartPosition[3] < blockCursorStartPosition[4] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 5)
+PASS blockCursorStartPosition[4] < blockCursorStartPosition[5] is true
+PASS getSelection().isCollapsed is true
+PASS blockCursor.width > 1 is true
+PASS internals.absoluteCaretBounds().width is 1
+getSelection().collapse(textNode, 6)
+PASS blockCursor.width is 0
+PASS internals.absoluteCaretBounds().width is 1
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
« no previous file with comments | « LayoutTests/editing/selection/block-cursor-overtype-mode.html ('k') | Source/core/editing/Editor.h » ('j') | Source/core/editing/Editor.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698