Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 1485893003: Make a content/test API for registering JNI. (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
jam
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, droger+watchlist_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make a content/test API for registering JNI. The components test setup needs to register browserJNI calls but this is not part of the content API. This makes a new content test wrapper API for doing this. This change fixes the components tests "gn check" failures so these targets can now be added to the whitelist. Cleans up the components/test DEPS file. The dependency allowances for this directory are quite wide so whitelisting every header file, as was done before, was needlessly complicated. Committed: https://crrev.com/7ae6a21024a9d8f1e7a43714e8d79f9a4a9aa27e Cr-Commit-Position: refs/heads/master@{#362476}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : namespace #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -27 lines) Patch
M .gn View 1 chunk +1 line, -1 line 0 comments Download
M components/test/DEPS View 1 chunk +7 lines, -24 lines 0 comments Download
M components/test/run_all_unittests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/test_utils.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M content/public/test/test_utils.cc View 1 2 2 chunks +11 lines, -0 lines 1 comment Download

Messages

Total messages: 23 (11 generated)
brettw
5 years ago (2015-12-01 00:27:17 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485893003/1
5 years ago (2015-12-01 00:30:21 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/147084) android_chromium_gn_compile_rel on ...
5 years ago (2015-12-01 01:09:03 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485893003/20001
5 years ago (2015-12-01 17:27:02 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/153120) linux_android_rel_ng on ...
5 years ago (2015-12-01 17:43:11 UTC) #11
brettw
namespace
5 years ago (2015-12-01 17:45:20 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485893003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485893003/40001
5 years ago (2015-12-01 17:45:45 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 19:00:36 UTC) #16
jam
lgtm https://codereview.chromium.org/1485893003/diff/40001/content/public/test/test_utils.cc File content/public/test/test_utils.cc (right): https://codereview.chromium.org/1485893003/diff/40001/content/public/test/test_utils.cc#newcode206 content/public/test/test_utils.cc:206: return content::android::RegisterBrowserJni(env); no content::
5 years ago (2015-12-01 19:14:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485893003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485893003/40001
5 years ago (2015-12-01 19:16:23 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-01 19:30:02 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-01 19:35:52 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7ae6a21024a9d8f1e7a43714e8d79f9a4a9aa27e
Cr-Commit-Position: refs/heads/master@{#362476}

Powered by Google App Engine
This is Rietveld 408576698