Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1485633002: Fix tracing_resources grit/generated file usage (Closed)

Created:
5 years ago by blundell
Modified:
5 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tracing_resources grit/generated file usage This CL fixes two problems in tracing_resources.gyp: (1) Multiple targets generate files that are then consumed by other targets but don't set themselves as hard dependencies. (2) The target processing the grd file doesn't have the resource_ids file as an input, so it is not rerun when that file changes. These problems were discovered in the course of shifting the location of some resources in the tree. Committed: https://crrev.com/cff7ec49d42148d19e67c614bcfff8e36f9592c9 Cr-Commit-Position: refs/heads/master@{#362786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/tracing/tracing_resources.gyp View 3 chunks +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
blundell
5 years ago (2015-11-30 12:56:11 UTC) #2
blundell
ping
5 years ago (2015-12-01 20:27:23 UTC) #3
dsinclair
I'm ooo until next week. Dan On Tue, Dec 1, 2015, 15:27 <blundell@chromium.org> wrote: > ...
5 years ago (2015-12-01 23:47:21 UTC) #4
blundell
Thanks (something some people do that works well is to reflect their OOO status in ...
5 years ago (2015-12-02 06:58:19 UTC) #6
nduca
lgtm
5 years ago (2015-12-02 17:37:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485633002/1
5 years ago (2015-12-02 19:29:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 20:44:50 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-02 20:45:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cff7ec49d42148d19e67c614bcfff8e36f9592c9
Cr-Commit-Position: refs/heads/master@{#362786}

Powered by Google App Engine
This is Rietveld 408576698