Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1467193003: Componentize error pages strings (Closed)

Created:
5 years ago by blundell
Modified:
5 years ago
Reviewers:
Nico, mmenke
CC:
chromium-reviews, dbeam+watch-options_chromium.org, kalyank, rginda+watch_chromium.org, michaelpg+watch-options_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize error pages strings As a step toward componentizing the LocalizedError class for clean integration on iOS, this CL componentizes error pages strings. BUG=523362 Committed: https://crrev.com/02d46ab5711051ad39480d47270b8653a276ce11 Cr-Commit-Position: refs/heads/master@{#362970}

Patch Set 1 #

Patch Set 2 : Remove cruft #

Patch Set 3 : Fix browser_tests #

Patch Set 4 : Rebase #

Patch Set 5 : Add hard_dependency to tracing_resources.gyp #

Patch Set 6 : Fix tracing_resources dependency #

Patch Set 7 : Re-add needed line #

Patch Set 8 : Split out tracing_resources fix #

Total comments: 10

Patch Set 9 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+788 lines, -794 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 3 4 5 2 chunks +0 lines, -50 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -651 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 3 4 5 2 chunks +0 lines, -50 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/localized_error.cc View 1 2 3 2 chunks +4 lines, -8 lines 0 comments Download
M components/components_chromium_strings.grd View 1 2 3 4 5 6 7 8 1 chunk +50 lines, -0 lines 0 comments Download
M components/components_google_chrome_strings.grd View 1 chunk +48 lines, -0 lines 0 comments Download
M components/error_page_strings.grdp View 1 2 3 4 5 6 7 8 2 chunks +645 lines, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +34 lines, -34 lines 0 comments Download

Depends on Patchset:

Issue 1485633002 Patch 1

Messages

Total messages: 23 (10 generated)
blundell
5 years ago (2015-11-30 12:56:54 UTC) #3
mmenke
https://codereview.chromium.org/1467193003/diff/140001/chrome/browser/errorpage_browsertest.cc File chrome/browser/errorpage_browsertest.cc (right): https://codereview.chromium.org/1467193003/diff/140001/chrome/browser/errorpage_browsertest.cc#newcode29 chrome/browser/errorpage_browsertest.cc:29: #include "chrome/grit/generated_resources.h" Still needed? https://codereview.chromium.org/1467193003/diff/140001/chrome/browser/ui/toolbar/toolbar_model_impl.cc File chrome/browser/ui/toolbar/toolbar_model_impl.cc (right): https://codereview.chromium.org/1467193003/diff/140001/chrome/browser/ui/toolbar/toolbar_model_impl.cc#newcode32 ...
5 years ago (2015-11-30 23:29:10 UTC) #4
blundell
https://codereview.chromium.org/1467193003/diff/140001/chrome/browser/errorpage_browsertest.cc File chrome/browser/errorpage_browsertest.cc (right): https://codereview.chromium.org/1467193003/diff/140001/chrome/browser/errorpage_browsertest.cc#newcode29 chrome/browser/errorpage_browsertest.cc:29: #include "chrome/grit/generated_resources.h" On 2015/11/30 23:29:10, mmenke wrote: > Still ...
5 years ago (2015-12-01 11:33:44 UTC) #5
mmenke
LGTM (Note that I'm not an owned for any file this CL touches, beyond the ...
5 years ago (2015-12-01 15:43:59 UTC) #6
blundell
thakis: Can you stamp everything other than the grd files and //components? Thanks!
5 years ago (2015-12-01 15:48:59 UTC) #8
Nico
lgtm
5 years ago (2015-12-01 16:02:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467193003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467193003/160001
5 years ago (2015-12-03 07:33:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/102371)
5 years ago (2015-12-03 09:00:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467193003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467193003/160001
5 years ago (2015-12-03 10:51:48 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/102438)
5 years ago (2015-12-03 12:27:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1467193003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1467193003/160001
5 years ago (2015-12-03 12:35:00 UTC) #19
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years ago (2015-12-03 13:24:04 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-03 13:25:08 UTC) #23
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/02d46ab5711051ad39480d47270b8653a276ce11
Cr-Commit-Position: refs/heads/master@{#362970}

Powered by Google App Engine
This is Rietveld 408576698