Revert of "[sql] Remove part of WebDatabase SQLite patch." (patchset #1 of https://codereview.chrom…

Revert of "[sql] Remove part of WebDatabase SQLite patch." (patchset #1 of https://codereview.chromium.org/1473963002 )

Reason for revert:

Unfortunately, this seems to have introduced flaky shutdown crashes on storage/websql/open-database-creation-callback.html across bots,

 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=storage%2Fwebsql%2Fopen-database-creation-callback.html

 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/5769

Original issue's description:
> [sql] Remove part of WebDatabase SQLite patch.
>
> findReusableFd() calls stat() on the filename to determine the inode
> and device to figure out if a previously-closed file descriptor can be
> reused.  Since WebDatabase file names are resolved by the browser,
> this stat() can never succeed in the renderer, thus there is no point
> to calling the function.
>
> This SQLite code path is an optimization to reduce close/open churn,
> it is not necessary for correct operation.
>
> BUG=none
>
> Review URL: https://codereview.chromium.org/1473963002
> Cr-Commit-Position: refs/heads/master@{#361825}

TBR=shess@chromium.org,michaeln@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Committed: https://crrev.com/94af7186bb57ba9e1a2dea4c2bd41ac5e418a18e
Cr-Commit-Position: refs/heads/master@{#362112}

[sof, 2015-11-30 09:41:50]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-11-30 09:42:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485603003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485603003/1

[commit-bot: I haz the power, 2015-11-30 09:43:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-30 09:44:01]

Description was changed from

==========
Revert of "[sql] Remove part of WebDatabase SQLite patch." (patchset #1 of
https://codereview.chromium.org/1473963002 )

Reason for revert:

Unfortunately, this seems to have introduced flaky shutdown crashes on
storage/websql/open-database-creation-callback.html across bots,


http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=sto...


http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/...

Original issue's description:
> [sql] Remove part of WebDatabase SQLite patch.
>
> findReusableFd() calls stat() on the filename to determine the inode
> and device to figure out if a previously-closed file descriptor can be
> reused.  Since WebDatabase file names are resolved by the browser,
> this stat() can never succeed in the renderer, thus there is no point
> to calling the function.
>
> This SQLite code path is an optimization to reduce close/open churn,
> it is not necessary for correct operation.
>
> BUG=none
>
> Review URL: https://codereview.chromium.org/1473963002
> Cr-Commit-Position: refs/heads/master@{#361825}

TBR=shess@chromium.org,michaeln@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Revert of "[sql] Remove part of WebDatabase SQLite patch." (patchset #1 of
https://codereview.chromium.org/1473963002 )

Reason for revert:

Unfortunately, this seems to have introduced flaky shutdown crashes on
storage/websql/open-database-creation-callback.html across bots,


http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=sto...


http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/...

Original issue's description:
> [sql] Remove part of WebDatabase SQLite patch.
>
> findReusableFd() calls stat() on the filename to determine the inode
> and device to figure out if a previously-closed file descriptor can be
> reused.  Since WebDatabase file names are resolved by the browser,
> this stat() can never succeed in the renderer, thus there is no point
> to calling the function.
>
> This SQLite code path is an optimization to reduce close/open churn,
> it is not necessary for correct operation.
>
> BUG=none
>
> Review URL: https://codereview.chromium.org/1473963002
> Cr-Commit-Position: refs/heads/master@{#361825}

TBR=shess@chromium.org,michaeln@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Committed: https://crrev.com/94af7186bb57ba9e1a2dea4c2bd41ac5e418a18e
Cr-Commit-Position: refs/heads/master@{#362112}
==========

[commit-bot: I haz the power, 2015-11-30 09:44:02]

Patchset 1 (id:??) landed as
https://crrev.com/94af7186bb57ba9e1a2dea4c2bd41ac5e418a18e
Cr-Commit-Position: refs/heads/master@{#362112}

[Scott Hess - ex-Googler, 2015-11-30 18:44:38]

Probably http://crbug.com/563319 .

On Mon, Nov 30, 2015 at 1:44 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/94af7186bb57ba9e1a2dea4c2bd41ac5e418a18e
> Cr-Commit-Position: refs/heads/master@{#362112}
>
> https://codereview.chromium.org/1485603003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Scott Hess - ex-Googler, 2015-11-30 18:44:39]

Probably http://crbug.com/563319 .

On Mon, Nov 30, 2015 at 1:44 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/94af7186bb57ba9e1a2dea4c2bd41ac5e418a18e
> Cr-Commit-Position: refs/heads/master@{#362112}
>
> https://codereview.chromium.org/1485603003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sof1, 2015-11-30 18:47:30]

Den 11/30/2015 19:44, Scott Hess skreiv:
> Probably http://crbug.com/563319 .
>

Can't access, but https://crbug.com/562440 overlap also?

--sigbjorn

> On Mon, Nov 30, 2015 at 1:44 AM, commit-bot@chromium.org
> <mailto:commit-bot@chromium.org> via codereview.chromium.org
> <http://codereview.chromium.org>
> <reply@chromiumcodereview-hr.appspotmail.com
> <mailto:reply@chromiumcodereview-hr.appspotmail.com>> wrote:
>
>     Patchset 1 (id:??) landed as
>     https://crrev.com/94af7186bb57ba9e1a2dea4c2bd41ac5e418a18e
>     Cr-Commit-Position: refs/heads/master@{#362112}
>
>     https://codereview.chromium.org/1485603003/
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[sof1, 2015-11-30 18:47:31]

Den 11/30/2015 19:44, Scott Hess skreiv:
> Probably http://crbug.com/563319 .
>

Can't access, but https://crbug.com/562440 overlap also?

--sigbjorn

> On Mon, Nov 30, 2015 at 1:44 AM, commit-bot@chromium.org
> <mailto:commit-bot@chromium.org> via codereview.chromium.org
> <http://codereview.chromium.org>
> <reply@chromiumcodereview-hr.appspotmail.com
> <mailto:reply@chromiumcodereview-hr.appspotmail.com>> wrote:
>
>     Patchset 1 (id:??) landed as
>     https://crrev.com/94af7186bb57ba9e1a2dea4c2bd41ac5e418a18e
>     Cr-Commit-Position: refs/heads/master@{#362112}
>
>     https://codereview.chromium.org/1485603003/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Scott Hess - ex-Googler, 2015-11-30 18:53:59]

Yep, I think that's the same, I'm still grinding through Monday Morning
Triage...

On Mon, Nov 30, 2015 at 10:47 AM, Sigbjorn Finne <sof@opera.com> wrote:

> Den 11/30/2015 19:44, Scott Hess skreiv:
>
>> Probably http://crbug.com/563319 .
>>
>>
> Can't access, but https://crbug.com/562440 overlap also?
>
> --sigbjorn
>
> On Mon, Nov 30, 2015 at 1:44 AM, commit-bot@chromium.org
>> <mailto:commit-bot@chromium.org> via codereview.chromium.org
>> <http://codereview.chromium.org>
>> <reply@chromiumcodereview-hr.appspotmail.com
>> <mailto:reply@chromiumcodereview-hr.appspotmail.com>> wrote:
>>
>>     Patchset 1 (id:??) landed as
>>     https://crrev.com/94af7186bb57ba9e1a2dea4c2bd41ac5e418a18e
>>     Cr-Commit-Position: refs/heads/master@{#362112}
>>
>>     https://codereview.chromium.org/1485603003/
>>
>>
>>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Scott Hess - ex-Googler, 2015-11-30 18:54:01]

Yep, I think that's the same, I'm still grinding through Monday Morning
Triage...

On Mon, Nov 30, 2015 at 10:47 AM, Sigbjorn Finne <sof@opera.com> wrote:

> Den 11/30/2015 19:44, Scott Hess skreiv:
>
>> Probably http://crbug.com/563319 .
>>
>>
> Can't access, but https://crbug.com/562440 overlap also?
>
> --sigbjorn
>
> On Mon, Nov 30, 2015 at 1:44 AM, commit-bot@chromium.org
>> <mailto:commit-bot@chromium.org> via codereview.chromium.org
>> <http://codereview.chromium.org>
>> <reply@chromiumcodereview-hr.appspotmail.com
>> <mailto:reply@chromiumcodereview-hr.appspotmail.com>> wrote:
>>
>>     Patchset 1 (id:??) landed as
>>     https://crrev.com/94af7186bb57ba9e1a2dea4c2bd41ac5e418a18e
>>     Cr-Commit-Position: refs/heads/master@{#362112}
>>
>>     https://codereview.chromium.org/1485603003/
>>
>>
>>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sof, 2015-11-30 19:01:10]

On 2015/11/30 18:54:01, Scott Hess wrote:
> Yep, I think that's the same, I'm still grinding through Monday Morning
> Triage...
> 

alright :)

fwiw, I failed to reproduce that crash locally nor can I see the test as flakily
failing on the https://codereview.chromium.org/1473963002 results.