[sql] Remove part of WebDatabase SQLite patch.

[sql] Remove part of WebDatabase SQLite patch.

findReusableFd() calls stat() on the filename to determine the inode
and device to figure out if a previously-closed file descriptor can be
reused.  Since WebDatabase file names are resolved by the browser,
this stat() can never succeed in the renderer, thus there is no point
to calling the function.

This SQLite code path is an optimization to reduce close/open churn,
it is not necessary for correct operation.

BUG=none

Committed: https://crrev.com/421491f00266f0c70cf3697de5565df31986f57f
Cr-Commit-Position: refs/heads/master@{#361825}

[Scott Hess - ex-Googler, 2015-11-25 19:14:54]

shess@chromium.org changed reviewers:
+ michaeln@chromium.org

[Scott Hess - ex-Googler, 2015-11-25 19:14:55]

I was pulling my mythical vfs-over-base implementation out of mothballs, and in
reviewing things TODO, realized that this part wasn't operational anyhow.

The part about keeping the list of open handles to the same dev/inode pair is
still important.  close() releases the locks for all handles in the current
process, so if a lock is held at close time, the handle still needs to go on the
list to be closed later.

https://codereview.chromium.org/1473963002/diff/1/third_party/sqlite/src/src/...
File third_party/sqlite/src/src/os_unix.c (right):

https://codereview.chromium.org/1473963002/diff/1/third_party/sqlite/src/src/...
third_party/sqlite/src/src/os_unix.c:5528: if( 0==osStat(zPath, &sStat) ){
This is the stat() I mean.

[michaeln, 2015-11-25 20:37:05]

lgtm!

[Scott Hess - ex-Googler, 2015-11-25 22:19:24]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2015-11-25 22:21:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1473963002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1473963002/1

[commit-bot: I haz the power, 2015-11-26 00:25:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 00:25:14]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[Scott Hess - ex-Googler, 2015-11-26 04:26:10]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2015-11-26 04:26:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1473963002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1473963002/1

[commit-bot: I haz the power, 2015-11-26 05:40:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-26 05:41:34]

Description was changed from

==========
[sql] Remove part of WebDatabase SQLite patch.

findReusableFd() calls stat() on the filename to determine the inode
and device to figure out if a previously-closed file descriptor can be
reused.  Since WebDatabase file names are resolved by the browser,
this stat() can never succeed in the renderer, thus there is no point
to calling the function.

This SQLite code path is an optimization to reduce close/open churn,
it is not necessary for correct operation.

BUG=none
==========

to

==========
[sql] Remove part of WebDatabase SQLite patch.

findReusableFd() calls stat() on the filename to determine the inode
and device to figure out if a previously-closed file descriptor can be
reused.  Since WebDatabase file names are resolved by the browser,
this stat() can never succeed in the renderer, thus there is no point
to calling the function.

This SQLite code path is an optimization to reduce close/open churn,
it is not necessary for correct operation.

BUG=none

Committed: https://crrev.com/421491f00266f0c70cf3697de5565df31986f57f
Cr-Commit-Position: refs/heads/master@{#361825}
==========

[commit-bot: I haz the power, 2015-11-26 05:41:35]

Patchset 1 (id:??) landed as
https://crrev.com/421491f00266f0c70cf3697de5565df31986f57f
Cr-Commit-Position: refs/heads/master@{#361825}

[sof, 2015-11-30 09:45:12]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2015-11-30 09:45:13]

Created a revert of this one via https://codereview.chromium.org/1485603003/
(Rietveld's "revert patchset" option balked about "file too large" (?) when
attempting to revert via it, hence going the manual route.)

[Scott Hess - ex-Googler, 2015-11-30 22:21:12]

On 2015/11/30 09:45:13, sof wrote:
> Created a revert of this one via https://codereview.chromium.org/1485603003/
> (Rietveld's "revert patchset" option balked about "file too large" (?) when
> attempting to revert via it, hence going the manual route.)

OK, I can repro the issues under asan.  The injected call always fails BUT it
always has side effects.  The existing flow of control is kind of derpy, I'll
look at patching things to have a single point of injection, but I'm not sure
that will be as satisfying.