Issue 14856016: Performance optimization of SubstringSetMatcher::InsertPatternIntoAhoCorasickTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14856016: Performance optimization of SubstringSetMatcher::InsertPatternIntoAhoCorasickTree (Closed)

Created:
7 years, 7 months ago by battre

Modified:
7 years, 7 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Performance optimization of SubstringSetMatcher::InsertPatternIntoAhoCorasickTree BUG=112155

Patch Set 1 #

Patch Set 2 : Minor tweak #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -13 lines)			Patch
	M	extensions/common/matcher/substring_set_matcher.cc	View	1	1 chunk	+14 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vabr (Chromium)

7 years, 7 months ago (2013-05-03 11:58:04 UTC) #2

Hi Dominic,

Have you done any benchmarks for this change?
I tried it with my benchmark, and it does not seem to perform better.

I like the eliminating of the HasEdge/GetEdge pattern as a general clean-up, and
I see a couple of more spots in the substring set matcher to improve on, but I
would wait with that until there is a change with a significant performance
improvement -- if such change requires substantial rewriting, all this clean-up
can be lost.

Also, maybe we should coordinate more -- parallel editing of the same spot in
code will result in colliding patches. I'm currently spending all my coding time
on the time optimisation for substring set matcher.

Vaclav

Expand Messages | Collapse Messages