Chromium Code Reviews| Index: media/audio/audio_output_resampler.cc |
| diff --git a/media/audio/audio_output_resampler.cc b/media/audio/audio_output_resampler.cc |
| index e6fcc56560484308bbb495984a63f8e3309a6985..69095a330374233b0004fe60ec6d1bedd90da6f9 100644 |
| --- a/media/audio/audio_output_resampler.cc |
| +++ b/media/audio/audio_output_resampler.cc |
| @@ -73,19 +73,20 @@ class OnMoreDataConverter |
| // Record UMA statistics for hardware output configuration. |
| static void RecordStats(const AudioParameters& output_params) { |
| UMA_HISTOGRAM_ENUMERATION( |
|
Ami GONE FROM CHROMIUM
2014/02/12 20:26:48
Maybe precede with a
// NOTE: PRESUBMIT_IGNORE_UMA
|
| - "Media.HardwareAudioBitsPerChannel", output_params.bits_per_sample(), |
| - limits::kMaxBitsPerSample); |
| + "Media.HardwareAudioBitsPerChannel", |
| + output_params.bits_per_sample(), |
| + limits::kMaxBitsPerSample); // PRESUBMIT_IGNORE_UMA_MAX |
| UMA_HISTOGRAM_ENUMERATION( |
| "Media.HardwareAudioChannelLayout", output_params.channel_layout(), |
| - CHANNEL_LAYOUT_MAX); |
| + CHANNEL_LAYOUT_MAX + 1); |
| UMA_HISTOGRAM_ENUMERATION( |
| "Media.HardwareAudioChannelCount", output_params.channels(), |
| - limits::kMaxChannels); |
| + limits::kMaxChannels); // PRESUBMIT_IGNORE_UMA_MAX |
| - AudioSampleRate asr = media::AsAudioSampleRate(output_params.sample_rate()); |
| - if (asr != kUnexpectedAudioSampleRate) { |
| + AudioSampleRate asr; |
| + if (media::ToAudioSampleRate(output_params.sample_rate(), &asr)) { |
| UMA_HISTOGRAM_ENUMERATION( |
| - "Media.HardwareAudioSamplesPerSecond", asr, kUnexpectedAudioSampleRate); |
| + "Media.HardwareAudioSamplesPerSecond", asr, kAudioSampleRateMax + 1); |
| } else { |
| UMA_HISTOGRAM_COUNTS( |
| "Media.HardwareAudioSamplesPerSecondUnexpected", |
| @@ -98,19 +99,20 @@ static void RecordFallbackStats(const AudioParameters& output_params) { |
| UMA_HISTOGRAM_BOOLEAN("Media.FallbackToHighLatencyAudioPath", true); |
| UMA_HISTOGRAM_ENUMERATION( |
| "Media.FallbackHardwareAudioBitsPerChannel", |
| - output_params.bits_per_sample(), limits::kMaxBitsPerSample); |
| + output_params.bits_per_sample(), |
| + limits::kMaxBitsPerSample); // PRESUBMIT_IGNORE_UMA_MAX |
| UMA_HISTOGRAM_ENUMERATION( |
| "Media.FallbackHardwareAudioChannelLayout", |
| - output_params.channel_layout(), CHANNEL_LAYOUT_MAX); |
| + output_params.channel_layout(), CHANNEL_LAYOUT_MAX + 1); |
| UMA_HISTOGRAM_ENUMERATION( |
| - "Media.FallbackHardwareAudioChannelCount", |
| - output_params.channels(), limits::kMaxChannels); |
| + "Media.FallbackHardwareAudioChannelCount", output_params.channels(), |
| + limits::kMaxChannels); // PRESUBMIT_IGNORE_UMA_MAX |
| - AudioSampleRate asr = media::AsAudioSampleRate(output_params.sample_rate()); |
| - if (asr != kUnexpectedAudioSampleRate) { |
| + AudioSampleRate asr; |
| + if (media::ToAudioSampleRate(output_params.sample_rate(), &asr)) { |
| UMA_HISTOGRAM_ENUMERATION( |
| "Media.FallbackHardwareAudioSamplesPerSecond", |
| - asr, kUnexpectedAudioSampleRate); |
| + asr, kAudioSampleRateMax + 1); |
| } else { |
| UMA_HISTOGRAM_COUNTS( |
| "Media.FallbackHardwareAudioSamplesPerSecondUnexpected", |