Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1485353006: Oilpan: no destructor needed for CSSPrimitiveValue. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: no destructor needed for CSSPrimitiveValue. Any unregistration is (already) taken care of by Oilpan. R=haraken BUG= Committed: https://crrev.com/bd4497d7318c066db5543bfa7cb04cf717fa81dd Cr-Commit-Position: refs/heads/master@{#362931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sof
please take a look.
5 years ago (2015-12-02 21:51:40 UTC) #3
haraken
LGTM
5 years ago (2015-12-02 23:52:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485353006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485353006/1
5 years ago (2015-12-03 06:33:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 07:29:53 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-03 07:31:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd4497d7318c066db5543bfa7cb04cf717fa81dd
Cr-Commit-Position: refs/heads/master@{#362931}

Powered by Google App Engine
This is Rietveld 408576698