Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp

Issue 1485353006: Oilpan: no destructor needed for CSSPrimitiveValue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValue.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
index 35c241c8ef912f2ddebc27f7d7a197bc78d7803a..de14f7a56637d737bf52b3e482ddc5cb745a6008 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
@@ -300,17 +300,11 @@ void CSSPrimitiveValue::init(PassRefPtrWillBeRawPtr<CSSCalcValue> c)
CSSPrimitiveValue::~CSSPrimitiveValue()
{
- cleanup();
-}
-
-void CSSPrimitiveValue::cleanup()
-{
+#if !ENABLE(OILPAN)
switch (type()) {
case UnitType::Calc:
// We must not call deref() when oilpan is enabled because m_value.calc is traced.
-#if !ENABLE(OILPAN)
m_value.calc->deref();
-#endif
break;
case UnitType::CalcPercentageWithNumber:
case UnitType::CalcPercentageWithLength:
@@ -355,6 +349,7 @@ void CSSPrimitiveValue::cleanup()
cssTextCache().remove(this);
m_hasCachedCSSText = false;
}
+#endif
}
double CSSPrimitiveValue::computeSeconds() const
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValue.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698