chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java - Issue 148523013: [Android] Rename TabBase to Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java

Issue 148523013: [Android] Rename TabBase to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2014_01_22_tabbase

Patch Set: sync Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellTab.java ('k') | chrome/browser/android/tab_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java

diff --git a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java

index 2ea18667cab91ed3488be4ee5c1e0305a28776da..7d791150c896080da4cabb05925d5a6d7229df40 100644

--- a/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java

+++ b/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java

@@ -19,7 +19,7 @@ import android.widget.TextView;

import android.widget.TextView.OnEditorActionListener;

import org.chromium.chrome.browser.EmptyTabObserver;

-import org.chromium.chrome.browser.TabBase;

+import org.chromium.chrome.browser.Tab;

import org.chromium.chrome.browser.TabObserver;

import org.chromium.chrome.browser.appmenu.AppMenuButtonHelper;

import org.chromium.chrome.browser.appmenu.AppMenuHandler;

@@ -56,7 +56,7 @@ public class TestShellToolbar extends LinearLayout {

/**

* The toolbar will visually represent the state of {@code tab}.

- * @param tab The TabBase that should be represented.

+ * @param tab The Tab that should be represented.

public void showTab(TestShellTab tab) {

if (mTab != null) mTab.removeObserver(mTabObserver);

@@ -147,12 +147,12 @@ public class TestShellToolbar extends LinearLayout {

private class TabObserverImpl extends EmptyTabObserver {

@Override

- public void onLoadProgressChanged(TabBase tab, int progress) {

+ public void onLoadProgressChanged(Tab tab, int progress) {

if (tab == mTab) TestShellToolbar.this.onLoadProgressChanged(progress);

}

@Override

- public void onUpdateUrl(TabBase tab, String url) {

+ public void onUpdateUrl(Tab tab, String url) {

if (tab == mTab) TestShellToolbar.this.onUpdateUrl(url);

}