Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 148523009: Use sys.exit rather than raise SystemExit (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
Reviewers:
iannucci1, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : ' instead of " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M win_toolchain/toolchain2013.py View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
iannucci1
kthxlgtm https://codereview.chromium.org/148523009/diff/1/win_toolchain/toolchain2013.py File win_toolchain/toolchain2013.py (right): https://codereview.chromium.org/148523009/diff/1/win_toolchain/toolchain2013.py#newcode159 win_toolchain/toolchain2013.py:159: sys.exit("After multiple retries, couldn't download Win8 SDK") annoying ...
6 years, 10 months ago (2014-01-28 17:43:18 UTC) #1
scottmg
https://codereview.chromium.org/148523009/diff/1/win_toolchain/toolchain2013.py File win_toolchain/toolchain2013.py (right): https://codereview.chromium.org/148523009/diff/1/win_toolchain/toolchain2013.py#newcode159 win_toolchain/toolchain2013.py:159: sys.exit("After multiple retries, couldn't download Win8 SDK") On 2014/01/28 ...
6 years, 10 months ago (2014-01-28 17:47:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/148523009/20001
6 years, 10 months ago (2014-01-28 17:47:32 UTC) #3
commit-bot: I haz the power
Presubmit check for 148523009-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 10 months ago (2014-01-28 17:49:13 UTC) #4
scottmg
On 2014/01/28 17:49:13, I haz the power (commit-bot) wrote: > Presubmit check for 148523009-20001 failed ...
6 years, 10 months ago (2014-01-28 17:59:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/148523009/20001
6 years, 10 months ago (2014-01-28 18:08:26 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-28 18:10:07 UTC) #7
Message was sent while issue was closed.
Change committed as 247469

Powered by Google App Engine
This is Rietveld 408576698