Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: win_toolchain/toolchain2013.py

Issue 148523009: Use sys.exit rather than raise SystemExit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: ' instead of " Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: win_toolchain/toolchain2013.py
diff --git a/win_toolchain/toolchain2013.py b/win_toolchain/toolchain2013.py
index 4b14214f551274ae0c91c11d7818a9bb74bb0727..47963f094a052ec51a7ad0f6abc3f12b4a488671 100755
--- a/win_toolchain/toolchain2013.py
+++ b/win_toolchain/toolchain2013.py
@@ -93,7 +93,7 @@ def Download(url, local_path):
sys.stdout.flush()
sys.stdout.write('\n')
if content_length and content_length != bytes_read:
- raise SystemExit('Got incorrect number of bytes downloading %s' % url)
+ sys.exit('Got incorrect number of bytes downloading %s' % url)
def ExtractIso(iso_path):
@@ -156,7 +156,7 @@ def DownloadSDK8():
return standalone_path
count += 1
sys.stdout.write('Windows 8 SDK failed to download, retrying.\n')
- raise SystemExit("After multiple retries, couldn't download Win8 SDK")
+ sys.exit('After multiple retries, couldn\'t download Win8 SDK')
def DownloadUsingGsutil(filename):
@@ -168,7 +168,7 @@ def DownloadUsingGsutil(filename):
download_from_google_storage.GSUTIL_DEFAULT_PATH, boto_path=None)
code = gsutil.call('cp', 'gs://chrome-wintoolchain/' + filename, target_path)
if code != 0:
- raise SystemExit('gsutil failed')
+ sys.exit('gsutil failed')
return target_path
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698