Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilderTest.java

Issue 148523004: Issue 16346. Ignore non-HTML template. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilderTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilderTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilderTest.java
index 3bcf6409db77e65c02e18d5d9851ca1137ae3e03..adc6c075c998bf76ec1d19371ac85753d23a668a 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilderTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilderTest.java
@@ -292,6 +292,22 @@ public class AngularCompilationUnitBuilderTest extends AngularTest {
assertMainErrors(AngularCode.MISSING_TEMPLATE_URL);
}
+ /**
+ * <p>
+ * https://code.google.com/p/dart/issues/detail?id=16346
+ */
+ public void test_NgComponent_bad_notHtmlTemplate() throws Exception {
+ contextHelper.addSource("/my_template", "");
+ contextHelper.addSource("/my_styles.css", "");
+ addMainSource(createAngularSource(//
+ "@NgComponent(publishAs: 'ctrl', selector: 'myComp',",
+ " templateUrl: 'my_template', cssUrl: 'my_styles.css')",
+ "class MyComponent {",
+ "}"));
+ contextHelper.runTasks();
+ // no exceptions, even though "my_template" is not an HTML file
+ }
+
public void test_NgComponent_bad_properties_invalidBinding() throws Exception {
contextHelper.addSource("/my_template.html", "");
contextHelper.addSource("/my_styles.css", "");

Powered by Google App Engine
This is Rietveld 408576698