editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilder.java - Issue 148523004: Issue 16346. Ignore non-HTML template.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilder.java

Issue 148523004: Issue 16346. Ignore non-HTML template. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilderTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilder.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilder.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilder.java

index 4bae2caa2c26496edb060350d5d13dfdd7ad7aeb..6167611ba7fc34c8bad96fa20705ea489d0840fd 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilder.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/AngularCompilationUnitBuilder.java

@@ -16,6 +16,7 @@ package com.google.dart.engine.internal.builder;

import com.google.common.annotations.VisibleForTesting;

import com.google.common.collect.Lists;

+import com.google.dart.engine.AnalysisEngine;

import com.google.dart.engine.ast.ASTNode;

import com.google.dart.engine.ast.Annotation;

import com.google.dart.engine.ast.ArgumentList;

@@ -488,7 +489,9 @@ public class AngularCompilationUnitBuilder {

if (templateSource == null || !templateSource.exists()) {

reportErrorForArgument(TEMPLATE_URL, AngularCode.URI_DOES_NOT_EXIST, templateUri);

}

- element.setTemplateSource(templateSource);

+ if (AnalysisEngine.isHtmlFileName(templateUri)) {

+ element.setTemplateSource(templateSource);

+ }

} catch (URISyntaxException exception) {

reportErrorForArgument(TEMPLATE_URL, AngularCode.INVALID_URI, templateUri);

}