Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1485143002: arm: Make sel build with clang's built-in assembler. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

arm: Make sel build with clang's built-in assembler. clang's integrated assembler only supports UAL, where sp is spelled sp and not %sp. Fixes the following error when building with clang's integrated assembler enabled: ../../native_client/src/trusted/service_runtime/linux/arm/sel_segments.c:13:7: error: unexpected token in operand asm("mov %0, %%sp" : "=r" (sp)); ^ <inline asm>:1:10: note: instantiated into assembly here mov r0, %sp ^ 1 error generated. BUG=chromium:124610 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/6f24c8ade6012005ceb41b4a2cc70a021d7f1d64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/trusted/service_runtime/linux/arm/sel_segments.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Nico
5 years ago (2015-12-01 15:38:34 UTC) #2
bradn
lgtm
5 years ago (2015-12-01 17:28:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485143002/1
5 years ago (2015-12-01 17:28:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: nacl-presubmit on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-presubmit/builds/470)
5 years ago (2015-12-01 17:30:33 UTC) #8
Nico
On 2015/12/01 17:30:33, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-01 17:31:23 UTC) #9
bradnelson
lgtm
5 years ago (2015-12-01 17:32:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485143002/1
5 years ago (2015-12-01 17:33:02 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-01 17:33:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/6f24c8ade...

Powered by Google App Engine
This is Rietveld 408576698