Eliminate ProfileOAuth2TokenService being a BCKS.

chrome/browser/signin/android_profile_oauth2_token_service.h

Index: chrome/browser/signin/android_profile_oauth2_token_service.h
diff --git a/chrome/browser/signin/android_profile_oauth2_token_service.h b/chrome/browser/signin/android_profile_oauth2_token_service.h
index 44876b2cfe95193960c7cf6a3f4c60f465a1eede..716846b3097c5ce0ae7daf456fb16bc957b9a180 100644
--- a/chrome/browser/signin/android_profile_oauth2_token_service.h
+++ b/chrome/browser/signin/android_profile_oauth2_token_service.h
@@ -68,7 +68,7 @@ class AndroidProfileOAuth2TokenService : public ProfileOAuth2TokenService {
   virtual void FireRefreshTokensLoadedFromJava(JNIEnv* env, jobject obj);
 
  protected:
-  friend class ProfileOAuth2TokenServiceFactory;
+  friend class ProfileOAuth2TokenServiceWrapperImpl;

[blundell, 2014/02/10 16:19:16]

Alternatively, perhaps I should just make these classes' constructors public?
That seems cleaner to me as I think about it.

[Roger Tawa OOO till Jul 10th, 2014/02/10 19:49:13]

In a non-BCKS world, like iOS, will the ctor need to be public?  If so, then
makes sense and would be cleaner.  Right now the advantage is that anyone who
wants to get a pointer to a PO2TS needs to call the factory.

[blundell, 2014/02/13 16:07:06]

Well the Android one won't need to be public to meet the needs of iOS, that's
for sure :). Will leave private for now.

On 2014/02/10 19:49:13, Roger Tawa wrote:

   AndroidProfileOAuth2TokenService();
   virtual ~AndroidProfileOAuth2TokenService();