Eliminate ProfileOAuth2TokenService being a BCKS.

chrome/browser/signin/android_profile_oauth2_token_service.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SIGNIN_ANDROID_PROFILE_OAUTH2_TOKEN_SERVICE_H_
 #define CHROME_BROWSER_SIGNIN_ANDROID_PROFILE_OAUTH2_TOKEN_SERVICE_H_
 
 #include <jni.h>
 #include <string>
 
@@ skipping 50 matching lines @@
   // Triggers a notification to all observers of the OAuth2TokenService that a
   // refresh token is now available.
   virtual void FireRefreshTokenRevokedFromJava(JNIEnv* env,
                                                jobject obj,
                                                const jstring account_name);
   // Triggers a notification to all observers of the OAuth2TokenService that all
   // refresh tokens have now been loaded.
   virtual void FireRefreshTokensLoadedFromJava(JNIEnv* env, jobject obj);
 
  protected:
-  friend class ProfileOAuth2TokenServiceFactory;
+  friend class ProfileOAuth2TokenServiceWrapperImpl;

[blundell, 2014/02/10 16:19:16]

Alternatively, perhaps I should just make these classes' constructors public?
That seems cleaner to me as I think about it.

[Roger Tawa OOO till Jul 10th, 2014/02/10 19:49:13]

In a non-BCKS world, like iOS, will the ctor need to be public?  If so, then
makes sense and would be cleaner.  Right now the advantage is that anyone who
wants to get a pointer to a PO2TS needs to call the factory.

[blundell, 2014/02/13 16:07:06]

Well the Android one won't need to be public to meet the needs of iOS, that's
for sure :). Will leave private for now.

On 2014/02/10 19:49:13, Roger Tawa wrote:

   AndroidProfileOAuth2TokenService();
   virtual ~AndroidProfileOAuth2TokenService();
 
   // Overridden from OAuth2TokenService to intercept token fetch requests and
   // redirect them to the Account Manager.
   virtual void FetchOAuth2Token(RequestImpl* request,
                                 const std::string& account_id,
                                 net::URLRequestContextGetter* getter,
                                 const std::string& client_id,
                                 const std::string& client_secret,
@@ skipping 14 matching lines @@
   // Called to notify observers when refresh tokans have been loaded.
   virtual void FireRefreshTokensLoaded() OVERRIDE;
 
  private:
   base::android::ScopedJavaGlobalRef<jobject> java_ref_;
 
   DISALLOW_COPY_AND_ASSIGN(AndroidProfileOAuth2TokenService);
 };
 
 #endif  // CHROME_BROWSER_SIGNIN_ANDROID_PROFILE_OAUTH2_TOKEN_SERVICE_H_