Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1485123002: Drop [LegacyInterfaceTypeChecking] for PagePopupController (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [LegacyInterfaceTypeChecking] for PagePopupController This is an internal API, used only by web/resources/listPicker.js, where document is passed as an argument, which is not null. BUG=561338 Committed: https://crrev.com/3dc774386c244b27cc5a28b1df033e1981639141 Cr-Commit-Position: refs/heads/master@{#362479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/page/PagePopupController.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/PagePopupController.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485123002/1
5 years ago (2015-12-01 14:40:35 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 16:25:17 UTC) #4
philipj_slow
PTAL an CQ?
5 years ago (2015-12-01 19:07:57 UTC) #6
Rick Byers
lgtm LGTM
5 years ago (2015-12-01 19:19:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485123002/1
5 years ago (2015-12-01 19:21:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 19:37:15 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-01 19:38:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dc774386c244b27cc5a28b1df033e1981639141
Cr-Commit-Position: refs/heads/master@{#362479}

Powered by Google App Engine
This is Rietveld 408576698