third_party/WebKit/Source/core/page/PagePopupController.cpp - Issue 1485123002: Drop [LegacyInterfaceTypeChecking] for PagePopupController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/PagePopupController.cpp

Issue 1485123002: Drop [LegacyInterfaceTypeChecking] for PagePopupController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/page/PagePopupController.cpp

diff --git a/third_party/WebKit/Source/core/page/PagePopupController.cpp b/third_party/WebKit/Source/core/page/PagePopupController.cpp

index be06d0937abace1ba5f770ddc005c2c477700b65..8bb10ab9cef10fcf9fa3a7b57be7b1a8570054f8 100644

--- a/third_party/WebKit/Source/core/page/PagePopupController.cpp

+++ b/third_party/WebKit/Source/core/page/PagePopupController.cpp

@@ -70,9 +70,9 @@ void PagePopupController::closePopup()

void PagePopupController::selectFontsFromOwnerDocument(Document* targetDocument)

{

- if (!targetDocument || !m_popupClient)

- return;

- m_popupClient->selectFontsFromOwnerDocument(*targetDocument);

+ ASSERT(targetDocument);

+ if (m_popupClient)

+ m_popupClient->selectFontsFromOwnerDocument(*targetDocument);

}

String PagePopupController::localizeNumberString(const String& numberString)

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/page/PagePopupController.idl » ('j') | no next file with comments »