Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Issue 1485103002: Fix CalculateGeneratorInputInfo for "xcode-ninja" generator. (Closed)

Created:
5 years ago by sdefresne
Modified:
5 years ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Fix CalculateGeneratorInputInfo for "xcode-ninja" generator. The function CalculateGeneratorInputInfo() was broken during patchset #2 of https://codereview.chromium.org/1477333003 (code setting the global should have been unindented). Fix the function to always set generator_filelist_paths whatever the flavour of "xcode" generator (vanilla or "ninja") is used. BUG=chromium:562135 R=mark@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/e2313c02ad7b6d589b38fe578f5d39970a9bbc20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M pylib/gyp/generator/xcode.py View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sdefresne
Sorry, I introduced a bug with patchset #2 of the previous issue. Can you take ...
5 years ago (2015-12-01 10:11:58 UTC) #2
Mark Mentovai
LGTM
5 years ago (2015-12-01 14:41:04 UTC) #3
sdefresne
5 years ago (2015-12-01 14:46:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e2313c02ad7b6d589b38fe578f5d39970a9bbc20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698