Generate response files in out/gypfiles when using xcode-ninja generator.

Generate response files out of the source tree with xcode & xcode-ninja.

Configure generator_filelist_paths used by main gyp input parse to build
path of "<|()" expansions file names when using "xcode" and "xcode-ninja"
generators to be out of the source tree.

The "xcode" generator will put the files in "xcodebuild/gypfiles" while
the "xcode-ninja" generator will use the same algorithm to generate the
file names as "ninja" generator (but using "gypfiles-xcode-ninja" as
last component of the path).

BUG=chromium:562135
R=mark@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/f4d65e35719cfe02257ece126c109cfc053ca35c

[sdefresne, 2015-11-27 18:58:52]

sdefresne@chromium.org changed reviewers:
+ mark@chromium.org

[sdefresne, 2015-11-27 18:58:53]

Please take a look.

[Mark Mentovai, 2015-11-27 21:43:40]

What happens if you’re not using xcode-ninja? The same thing as before,
littering the source tree?

We should probably cover that case too by putting the rsp files somewhere in
Xcode’s output directory.

[sdefresne, 2015-11-30 14:04:13]

Description was changed from

==========
Generate response files in out/gypfiles when using xcode-ninja generator.

Configure generator_filelist_paths used by main gyp input parser to
build path of "<|()" expansions file names when using "xcode-ninja"
generator to be similar to what is used by "ninja" generator. Use a
slightly different path so that files are not overwritten.

BUG=chromium:562135
==========

to

==========
Generate response files out of the source tree with xcode & xcode-ninja.

Configure generator_filelist_paths used by main gyp input parse to build
path of "<|()" expansions file names when using "xcode" and "xcode-ninja"
generators to be out of the source tree.

The "xcode" generator will put the files in "xcodebuild/gypfiles" while
the "xcode-ninja" generator will use the same algorithm to generate the
file names as "ninja" generator (but using "gypfiles-xcode-ninja" as
last component of the path).

BUG=chromium:562135
==========

[sdefresne, 2015-11-30 14:05:58]

Done, please take another look.

With this patch, the .rsp files when generating gyp files for Chromium on iOS
are in:
- out/gypfiles-xcode-ninja when using xcode-ninja generator
- xcodebuild/gypfiles when using xcode generator.

[Mark Mentovai, 2015-11-30 14:22:53]

https://codereview.chromium.org/1477333003/diff/20001/pylib/gyp/generator/xco...
File pylib/gyp/generator/xcode.py (right):

https://codereview.chromium.org/1477333003/diff/20001/pylib/gyp/generator/xco...
pylib/gyp/generator/xcode.py:592: output_dir =
os.path.normpath(os.path.join(toplevel, 'xcodebuild'))
Can you not hardcode xcodebuild? This is not the default. Chrome pushes this
string in to the SYMROOT xcode_setting in build/common.gypi. Can you pick up
SYMROOT here?

[sdefresne, 2015-11-30 14:48:01]

On 2015/11/30 at 14:22:53, mark wrote:
>
https://codereview.chromium.org/1477333003/diff/20001/pylib/gyp/generator/xco...
> File pylib/gyp/generator/xcode.py (right):
> 
>
https://codereview.chromium.org/1477333003/diff/20001/pylib/gyp/generator/xco...
> pylib/gyp/generator/xcode.py:592: output_dir =
os.path.normpath(os.path.join(toplevel, 'xcodebuild'))
> Can you not hardcode xcodebuild? This is not the default. Chrome pushes this
string in to the SYMROOT xcode_setting in build/common.gypi. Can you pick up
SYMROOT here?

It's going to be tricky.

CalculateGeneratorInputInfo() is called from pylib/gyp/__init__.py method Load()
before loading the project, so it does not have access to the value defined in
build/common.gypi. The value computed from CalculateGeneratorInputInto() is used
in pylib/gyp/input.py that has no knowledge of xcode generator (i.e. it does not
have access to SYMROOT) and cannot substitute $(SYMROOT) with the correct value.

The only code with knowledge of SYMROOT is in pylib/gyp/xcodeproj_file.py, but
I'm not sure it is correct to override the value of pylib/gyp/xcode.py global
generator_filelist_paths['qualified_out_dir'] there. I'm not even sure it would
work, as I'm afraid it would be called too late (i.e. after parsing is
complete).

I think the problem comes from the fact that the .rsp files are generated at
parsing time, while SYMROOT value is only known later during project generation.
One possibility is to add a new parameter to the xcode generator and set a
default value in Chromium src/build/gyp_chromium.py to be the same as what is
used in build/common.gypi. WDYT?

[Mark Mentovai, 2015-11-30 14:55:27]

I see. I agree, that’s pretty tricky. It’s probably not worthwhile for a fringe
feature in an infrequently-used (by our team) configuration. LGTM as-is.

[sdefresne, 2015-11-30 15:57:34]

Description was changed from

==========
Generate response files out of the source tree with xcode & xcode-ninja.

Configure generator_filelist_paths used by main gyp input parse to build
path of "<|()" expansions file names when using "xcode" and "xcode-ninja"
generators to be out of the source tree.

The "xcode" generator will put the files in "xcodebuild/gypfiles" while
the "xcode-ninja" generator will use the same algorithm to generate the
file names as "ninja" generator (but using "gypfiles-xcode-ninja" as
last component of the path).

BUG=chromium:562135
==========

to

==========
Generate response files out of the source tree with xcode & xcode-ninja.

Configure generator_filelist_paths used by main gyp input parse to build
path of "<|()" expansions file names when using "xcode" and "xcode-ninja"
generators to be out of the source tree.

The "xcode" generator will put the files in "xcodebuild/gypfiles" while
the "xcode-ninja" generator will use the same algorithm to generate the
file names as "ninja" generator (but using "gypfiles-xcode-ninja" as
last component of the path).

BUG=chromium:562135
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/external/gyp/+/f4d65e35719cfe02257ece126c10...
==========

[sdefresne, 2015-11-30 15:57:37]

Committed patchset #2 (id:20001) manually as
f4d65e35719cfe02257ece126c109cfc053ca35c (presubmit successful).