ui: use base's ContainsValue helper function instead of std::find

ui: use base's ContainsValue helper function instead of std::find

This simplifies many conditions around the code.

BUG=561800
R=sky@chromium.org

Committed: https://crrev.com/07a1179cba4c362871d82ee40abe2a985f5b38b6
Cr-Commit-Position: refs/heads/master@{#362863}

[tfarina, 2015-12-01 21:05:26]

PTAL.

[sky, 2015-12-01 22:08:31]

LGTM

https://codereview.chromium.org/1485093003/diff/1/ui/base/ime/win/tsf_input_s...
File ui/base/ime/win/tsf_input_scope.cc (left):

https://codereview.chromium.org/1485093003/diff/1/ui/base/ime/win/tsf_input_s...
ui/base/ime/win/tsf_input_scope.cc:7: #include <algorithm>
I suspect you can nuke this include from all these files, but you'll have to
verify that.

https://codereview.chromium.org/1485093003/diff/1/ui/base/x/x11_util.cc
File ui/base/x/x11_util.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/base/x/x11_util.cc#newco...
ui/base/x/x11_util.cc:562: if (ContainsValue(wm_states, hidden_atom)) {
nit: nuke {}

https://codereview.chromium.org/1485093003/diff/1/ui/gl/gl_gl_api_implementat...
File ui/gl/gl_gl_api_implementation.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/gl/gl_gl_api_implementat...
ui/gl/gl_gl_api_implementation.cc:495: if (!ContainsValue(disabled_exts_,
gl_extension)) {
nit: nuke {}

https://codereview.chromium.org/1485093003/diff/1/ui/gl/gl_surface.cc
File ui/gl/gl_surface.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/gl/gl_surface.cc#newcode54
ui/gl/gl_surface.cc:54: if (!ContainsValue(allowed_impls, impl)) {
nit: nuke {}

https://codereview.chromium.org/1485093003/diff/1/ui/message_center/message_c...
File ui/message_center/message_center_impl.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/message_center/message_c...
ui/message_center/message_center_impl.cc:385: if (ContainsValue(blockers_,
blocker)) {
nit: nuke {}

https://codereview.chromium.org/1485093003/diff/1/ui/views/view.cc
File ui/views/view.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/views/view.cc#newcode1094
ui/views/view.cc:1094: if (!ContainsValue(accelerators_.get(), accelerator)) {
nit: nuke {}

https://codereview.chromium.org/1485093003/diff/1/ui/wm/core/window_animation...
File ui/wm/core/window_animations.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/wm/core/window_animation...
ui/wm/core/window_animations.cc:98: if (ContainsValue(transient_children,
*iter)) {
nit: nuke {}

[tfarina, 2015-12-02 20:31:41]

https://codereview.chromium.org/1485093003/diff/1/ui/base/ime/win/tsf_input_s...
File ui/base/ime/win/tsf_input_scope.cc (left):

https://codereview.chromium.org/1485093003/diff/1/ui/base/ime/win/tsf_input_s...
ui/base/ime/win/tsf_input_scope.cc:7: #include <algorithm>
On 2015/12/01 22:08:31, sky wrote:
> I suspect you can nuke this include from all these files, but you'll have to
> verify that.

Done.

https://codereview.chromium.org/1485093003/diff/1/ui/base/x/x11_util.cc
File ui/base/x/x11_util.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/base/x/x11_util.cc#newco...
ui/base/x/x11_util.cc:562: if (ContainsValue(wm_states, hidden_atom)) {
On 2015/12/01 22:08:31, sky wrote:
> nit: nuke {}

Done.

https://codereview.chromium.org/1485093003/diff/1/ui/gl/gl_gl_api_implementat...
File ui/gl/gl_gl_api_implementation.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/gl/gl_gl_api_implementat...
ui/gl/gl_gl_api_implementation.cc:495: if (!ContainsValue(disabled_exts_,
gl_extension)) {
On 2015/12/01 22:08:31, sky wrote:
> nit: nuke {}

Done.

https://codereview.chromium.org/1485093003/diff/1/ui/gl/gl_surface.cc
File ui/gl/gl_surface.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/gl/gl_surface.cc#newcode54
ui/gl/gl_surface.cc:54: if (!ContainsValue(allowed_impls, impl)) {
On 2015/12/01 22:08:31, sky wrote:
> nit: nuke {}

Done.

https://codereview.chromium.org/1485093003/diff/1/ui/message_center/message_c...
File ui/message_center/message_center_impl.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/message_center/message_c...
ui/message_center/message_center_impl.cc:385: if (ContainsValue(blockers_,
blocker)) {
On 2015/12/01 22:08:31, sky wrote:
> nit: nuke {}

Done.

https://codereview.chromium.org/1485093003/diff/1/ui/views/view.cc
File ui/views/view.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/views/view.cc#newcode1094
ui/views/view.cc:1094: if (!ContainsValue(accelerators_.get(), accelerator)) {
On 2015/12/01 22:08:31, sky wrote:
> nit: nuke {}

Done.

https://codereview.chromium.org/1485093003/diff/1/ui/wm/core/window_animation...
File ui/wm/core/window_animations.cc (right):

https://codereview.chromium.org/1485093003/diff/1/ui/wm/core/window_animation...
ui/wm/core/window_animations.cc:98: if (ContainsValue(transient_children,
*iter)) {
On 2015/12/01 22:08:31, sky wrote:
> nit: nuke {}

Done.

[tfarina, 2015-12-02 20:31:46]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-12-02 20:31:46]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1485093003/#ps20001
(title: "review + view.cc fix")

[commit-bot: I haz the power, 2015-12-02 20:32:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485093003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485093003/20001

[commit-bot: I haz the power, 2015-12-02 21:36:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 21:36:15]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tfarina, 2015-12-03 00:52:35]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-12-03 00:55:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485093003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485093003/20001

[commit-bot: I haz the power, 2015-12-03 02:07:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-03 02:09:21]

Description was changed from

==========
ui: use base's ContainsValue helper function instead of std::find

This simplifies many conditions around the code.

BUG=561800
R=sky@chromium.org
==========

to

==========
ui: use base's ContainsValue helper function instead of std::find

This simplifies many conditions around the code.

BUG=561800
R=sky@chromium.org

Committed: https://crrev.com/07a1179cba4c362871d82ee40abe2a985f5b38b6
Cr-Commit-Position: refs/heads/master@{#362863}
==========

[commit-bot: I haz the power, 2015-12-03 02:09:22]

Patchset 2 (id:??) landed as
https://crrev.com/07a1179cba4c362871d82ee40abe2a985f5b38b6
Cr-Commit-Position: refs/heads/master@{#362863}