Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: ui/gl/gl_gl_api_implementation.cc

Issue 1485093003: ui: use base's ContainsValue helper function instead of std::find (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/gl/gl_gl_api_implementation.h" 5 #include "ui/gl/gl_gl_api_implementation.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/stl_util.h"
11 #include "base/strings/string_split.h" 12 #include "base/strings/string_split.h"
12 #include "base/strings/string_util.h" 13 #include "base/strings/string_util.h"
13 #include "ui/gl/gl_context.h" 14 #include "ui/gl/gl_context.h"
14 #include "ui/gl/gl_implementation.h" 15 #include "ui/gl/gl_implementation.h"
15 #include "ui/gl/gl_state_restorer.h" 16 #include "ui/gl/gl_state_restorer.h"
16 #include "ui/gl/gl_surface.h" 17 #include "ui/gl/gl_surface.h"
17 #include "ui/gl/gl_switches.h" 18 #include "ui/gl/gl_switches.h"
18 #include "ui/gl/gl_version_info.h" 19 #include "ui/gl/gl_version_info.h"
19 20
20 namespace gfx { 21 namespace gfx {
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 disabled_exts_); 485 disabled_exts_);
485 filtered_exts_ = base::SplitString( 486 filtered_exts_ = base::SplitString(
486 filtered_exts_str_, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); 487 filtered_exts_str_, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
487 } else { 488 } else {
488 GLint num_extensions = 0; 489 GLint num_extensions = 0;
489 GLApiBase::glGetIntegervFn(GL_NUM_EXTENSIONS, &num_extensions); 490 GLApiBase::glGetIntegervFn(GL_NUM_EXTENSIONS, &num_extensions);
490 for (GLint i = 0; i < num_extensions; ++i) { 491 for (GLint i = 0; i < num_extensions; ++i) {
491 const char* gl_extension = reinterpret_cast<const char*>( 492 const char* gl_extension = reinterpret_cast<const char*>(
492 GLApiBase::glGetStringiFn(GL_EXTENSIONS, i)); 493 GLApiBase::glGetStringiFn(GL_EXTENSIONS, i));
493 DCHECK(gl_extension != NULL); 494 DCHECK(gl_extension != NULL);
494 if (std::find(disabled_exts_.begin(), disabled_exts_.end(), 495 if (!ContainsValue(disabled_exts_, gl_extension)) {
sky 2015/12/01 22:08:31 nit: nuke {}
tfarina 2015/12/02 20:31:41 Done.
495 gl_extension) == disabled_exts_.end()) {
496 filtered_exts_.push_back(gl_extension); 496 filtered_exts_.push_back(gl_extension);
497 } 497 }
498 } 498 }
499 filtered_exts_str_ = base::JoinString(filtered_exts_, " "); 499 filtered_exts_str_ = base::JoinString(filtered_exts_, " ");
500 } 500 }
501 #if DCHECK_IS_ON() 501 #if DCHECK_IS_ON()
502 filtered_exts_initialized_ = true; 502 filtered_exts_initialized_ = true;
503 #endif 503 #endif
504 } 504 }
505 } 505 }
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 611
612 void VirtualGLApi::glFlushFn() { 612 void VirtualGLApi::glFlushFn() {
613 GLApiBase::glFlushFn(); 613 GLApiBase::glFlushFn();
614 } 614 }
615 615
616 void VirtualGLApi::glFinishFn() { 616 void VirtualGLApi::glFinishFn() {
617 GLApiBase::glFinishFn(); 617 GLApiBase::glFinishFn();
618 } 618 }
619 619
620 } // namespace gfx 620 } // namespace gfx
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698