Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 14850004: Revert 197865 "dbus: Use fakes for some clients and utils for Mo..." (Closed)

Created:
7 years, 7 months ago by Haruki Sato
Modified:
7 years, 7 months ago
Reviewers:
Haruki Sato
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 197865 "dbus: Use fakes for some clients and utils for Mo..." > dbus: Use fakes for some clients and utils for MockDBusThreadManagerWithoutGMock > > Fakes are used for > - PowerManagerClient (with a PowerPolicyController instance) > - SessionManagerClient > - UpdateEngineClient > > BUG=234084 > TEST=trybots > R=satorux@chromium.org > > Review URL: https://codereview.chromium.org/14392007 TBR=haruki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -28 lines) Patch
M trunk/src/chromeos/chromeos.gyp View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chromeos/dbus/mock_dbus_thread_manager_without_gmock.h View 3 chunks +1 line, -8 lines 0 comments Download
M trunk/src/chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc View 6 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Haruki Sato
7 years, 7 months ago (2013-05-02 08:50:12 UTC) #1
Haruki Sato
7 years, 7 months ago (2013-05-02 08:50:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r197869.

Powered by Google App Engine
This is Rietveld 408576698