dbus: Use stubs for some clients and utils for MockDBusThreadManagerWithoutGMock

dbus: Use fakes for some clients and utils for MockDBusThreadManagerWithoutGMock

Fakes are used for
- PowerManagerClient (with a PowerPolicyController instance)
- SessionManagerClient
- UpdateEngineClient

BUG=234084
TEST=trybots
R=satorux@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197865

[satorux1, 2013-04-25 07:42:03]

https://codereview.chromium.org/14392007/diff/2001/chromeos/dbus/mock_dbus_th...
File chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc (right):

https://codereview.chromium.org/14392007/diff/2001/chromeos/dbus/mock_dbus_th...
chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc:59:
SystemClockClient::Create(STUB_DBUS_CLIENT_IMPLEMENTATION, NULL)),
using stubs sounds may be questionable. for now, could you remove them in this
patch?

[Haruki Sato, 2013-04-25 07:51:47]

https://codereview.chromium.org/14392007/diff/2001/chromeos/dbus/mock_dbus_th...
File chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc (right):

https://codereview.chromium.org/14392007/diff/2001/chromeos/dbus/mock_dbus_th...
chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc:59:
SystemClockClient::Create(STUB_DBUS_CLIENT_IMPLEMENTATION, NULL)),
Do you mean we can add them when necessary? or
Are you suggesting to add empty fakes for these?

[satorux1, 2013-04-25 07:57:03]

https://codereview.chromium.org/14392007/diff/2001/chromeos/dbus/mock_dbus_th...
File chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc (right):

https://codereview.chromium.org/14392007/diff/2001/chromeos/dbus/mock_dbus_th...
chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc:59:
SystemClockClient::Create(STUB_DBUS_CLIENT_IMPLEMENTATION, NULL)),
On 2013/04/25 07:51:47, Haruki Sato wrote:
> Do you mean we can add them when necessary? or
> Are you suggesting to add empty fakes for these?

For the new bluetooth code, keybuk@ stopped providing Stub* classes. Please take
a look at https://chromiumcodereview.appspot.com/14048007 (ex.
fake_bluetooth_input_client.h)

I think we should follow this fashion.

[Haruki Sato, 2013-04-25 08:54:14]

On 2013/04/25 07:57:03, satorux1 wrote:
>
https://codereview.chromium.org/14392007/diff/2001/chromeos/dbus/mock_dbus_th...
> File chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc (right):
> 
>
https://codereview.chromium.org/14392007/diff/2001/chromeos/dbus/mock_dbus_th...
> chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc:59:
> SystemClockClient::Create(STUB_DBUS_CLIENT_IMPLEMENTATION, NULL)),
> On 2013/04/25 07:51:47, Haruki Sato wrote:
> > Do you mean we can add them when necessary? or
> > Are you suggesting to add empty fakes for these?
> 
> For the new bluetooth code, keybuk@ stopped providing Stub* classes. Please
take
> a look at https://chromiumcodereview.appspot.com/14048007 (ex.
> fake_bluetooth_input_client.h)
> 
> I think we should follow this fashion.

OK, then I'll go adding fakes for those clients.

[Haruki Sato, 2013-04-25 15:42:23]

As I sent out another CL, 
Stubs for ImageBurnerClient and SystemClockClient are removed from this CL,
and we'll use fakes for them and SessionManagerClient.

As for Bluetooth*Client-s, they will be removed in a few weeks anyway. 
Do you think we can use these stubs for now and work on replacing
MockDBusThreadManager with MockDBusThreadManagerWithoutGMock? With these 3
clients, some of browser_tests can run with MockDBusThreadManagerWithoutGMock.

WDYT?

[satorux1, 2013-04-26 04:44:40]

please also update the patch description.

https://codereview.chromium.org/14392007/diff/8002/chromeos/dbus/mock_dbus_th...
File chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc (right):

https://codereview.chromium.org/14392007/diff/8002/chromeos/dbus/mock_dbus_th...
chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc:51:
BluetoothManagerClient::Create(STUB_DBUS_CLIENT_IMPLEMENTATION, NULL)),
please do: new FakeBluetoothManagerClient

[Haruki Sato, 2013-04-26 08:56:47]

Factored out the old Bluetooth*Clients as FakeOldBluetooth*Clients and
sent a code review as https://codereview.chromium.org/14508007/

Also this CL is updated based on 14508007.

PTAL. Thanks.

[satorux1, 2013-05-01 04:39:58]

https://codereview.chromium.org/14392007/diff/13010/chromeos/dbus/mock_dbus_t...
File chromeos/dbus/mock_dbus_thread_manager_without_gmock.h (right):

https://codereview.chromium.org/14392007/diff/13010/chromeos/dbus/mock_dbus_t...
chromeos/dbus/mock_dbus_thread_manager_without_gmock.h:191:
scoped_ptr<PowerPolicyController> power_policy_controller_;
Is it ok to use the real implementation? Looks this class does a lot of things.

[Haruki Sato, 2013-05-01 05:38:58]

https://codereview.chromium.org/14392007/diff/13010/chromeos/dbus/mock_dbus_t...
File chromeos/dbus/mock_dbus_thread_manager_without_gmock.h (right):

https://codereview.chromium.org/14392007/diff/13010/chromeos/dbus/mock_dbus_t...
chromeos/dbus/mock_dbus_thread_manager_without_gmock.h:191:
scoped_ptr<PowerPolicyController> power_policy_controller_;
On 2013/05/01 04:39:58, satorux1 wrote:
> Is it ok to use the real implementation? Looks this class does a lot of
things.

It's a kind of translator or or a wrapper of PowerManagerClient.
MockDBusThreadManager is already doing the same thing.
https://code.google.com/p/chromium/codesearch#chromium/src/chromeos/dbus/mock...
For our purpose, I think we can do this.
WDYT?

[satorux1, 2013-05-01 05:46:51]

On 2013/05/01 05:38:58, Haruki Sato wrote:
>
https://codereview.chromium.org/14392007/diff/13010/chromeos/dbus/mock_dbus_t...
> File chromeos/dbus/mock_dbus_thread_manager_without_gmock.h (right):
> 
>
https://codereview.chromium.org/14392007/diff/13010/chromeos/dbus/mock_dbus_t...
> chromeos/dbus/mock_dbus_thread_manager_without_gmock.h:191:
> scoped_ptr<PowerPolicyController> power_policy_controller_;
> On 2013/05/01 04:39:58, satorux1 wrote:
> > Is it ok to use the real implementation? Looks this class does a lot of
> things.
> 
> It's a kind of translator or or a wrapper of PowerManagerClient.
> MockDBusThreadManager is already doing the same thing.
>
https://code.google.com/p/chromium/codesearch#chromium/src/chromeos/dbus/mock...
> For our purpose, I think we can do this.
> WDYT?

LGTM

[commit-bot: I haz the power, 2013-05-01 07:56:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haruki@chromium.org/14392007/13010

[commit-bot: I haz the power, 2013-05-01 07:56:31]

Failed to apply patch for chromeos/chromeos.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chromeos/chromeos.gyp
  Hunk #1 succeeded at 326 (offset 10 lines).
  Hunk #2 FAILED at 392.
  1 out of 2 hunks FAILED -- saving rejects to file chromeos/chromeos.gyp.rej

Patch:       chromeos/chromeos.gyp
Index: chromeos/chromeos.gyp
diff --git a/chromeos/chromeos.gyp b/chromeos/chromeos.gyp
index
7090511d52a9142060e590833713121c73c26837..006b1847c0bb3bd2968410257327d7bba994b726
100644
--- a/chromeos/chromeos.gyp
+++ b/chromeos/chromeos.gyp
@@ -316,10 +316,6 @@
         'cryptohome/mock_async_method_caller.h',
         'cryptohome/mock_cryptohome_library.cc',
         'cryptohome/mock_cryptohome_library.h',
-        'dbus/fake_session_manager_client.cc',
-        'dbus/fake_session_manager_client.h',
-        'dbus/fake_update_engine_client.cc',
-        'dbus/fake_update_engine_client.h',
         'dbus/mock_bluetooth_adapter_client.cc',
         'dbus/mock_bluetooth_adapter_client.h',
         'dbus/mock_bluetooth_device_client.cc',
@@ -396,6 +392,10 @@
         'dbus/fake_power_manager_client.h',
         'dbus/fake_shill_manager_client.cc',
         'dbus/fake_shill_manager_client.h',
+        'dbus/fake_session_manager_client.cc',
+        'dbus/fake_session_manager_client.h',
+        'dbus/fake_update_engine_client.cc',
+        'dbus/fake_update_engine_client.h',
         'dbus/mock_dbus_thread_manager_without_gmock.cc',
         'dbus/mock_dbus_thread_manager_without_gmock.h',
         'dbus/ibus/mock_ibus_client.cc',

[Haruki Sato, 2013-05-02 08:08:44]

Committed patchset #9 manually as r197865 (presubmit successful).