Issue 1484983002: [Offline pages] Making sure visit button works on tablet

Issue 1484983002: [Offline pages] Making sure visit button works on tablet (Closed)

Created:
5 years ago by fgorski

Modified:
5 years ago

Reviewers:
Kibeom Kim (inactive)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

[Offline pages] Making sure visit button works on tablet Per suggestion from kkimlabs@ this patch: * Moves a piece of logic responsible for opening bookmarks from EnhancedBookmarkManager to EnhancedBookmarkUtils * Calls EnhancedBookmarkUtils#openBookmark from EnhancedBookmarkEditActivity when handling the Visit button. BUG=560133 R=kkimlabs@chromium.org Review URL: https://codereview.chromium.org/1475513008 Cr-Commit-Position: refs/heads/master@{#361809} (cherry picked from commit 34b66e5f77f6efa3708efda9d0fc099881b1fedf) Committed: https://chromium.googlesource.com/chromium/src/+/cc4fc018cd61ee80ab834177896bf3ace83417b5

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -22 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java	View	2 chunks	+11 lines, -3 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java	View	3 chunks	+2 lines, -17 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java	View	4 chunks	+35 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

fgorski

5 years ago (2015-11-30 23:02:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cc4fc018cd61ee80ab834177896bf3ace83417b5.