Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 1475513008: [Offline pages] Making sure visit button works on tablet (Closed)

Created:
5 years ago by fgorski
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Making sure visit button works on tablet Per suggestion from kkimlabs@ this patch: * Moves a piece of logic responsible for opening bookmarks from EnhancedBookmarkManager to EnhancedBookmarkUtils * Calls EnhancedBookmarkUtils#openBookmark from EnhancedBookmarkEditActivity when handling the Visit button. BUG=560133 R=kkimlabs@chromium.org Committed: https://crrev.com/34b66e5f77f6efa3708efda9d0fc099881b1fedf Cr-Commit-Position: refs/heads/master@{#361809}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
fgorski
PTAL
5 years ago (2015-11-26 00:19:44 UTC) #1
Kibeom Kim (inactive)
lgtm
5 years ago (2015-11-26 00:24:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475513008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475513008/1
5 years ago (2015-11-26 03:40:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 03:55:27 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-26 03:56:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34b66e5f77f6efa3708efda9d0fc099881b1fedf
Cr-Commit-Position: refs/heads/master@{#361809}

Powered by Google App Engine
This is Rietveld 408576698