Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Side by Side Diff: build/config/android/BUILD.gn

Issue 1484883002: clang/arm: Push -no-integrated-as into the four targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/sanitizers/sanitizers.gni") 6 import("//build/config/sanitizers/sanitizers.gni")
7 import("//build/config/sysroot.gni") 7 import("//build/config/sysroot.gni")
8 8
9 assert(is_android) 9 assert(is_android)
10 10
(...skipping 15 matching lines...) Expand all
26 ] 26 ]
27 ldflags = [] 27 ldflags = []
28 28
29 if (!is_clang) { 29 if (!is_clang) {
30 # Clang doesn't support these flags. 30 # Clang doesn't support these flags.
31 cflags += [ "-finline-limit=64" ] 31 cflags += [ "-finline-limit=64" ]
32 } 32 }
33 if (is_clang) { 33 if (is_clang) {
34 rebased_android_toolchain_root = 34 rebased_android_toolchain_root =
35 rebase_path(android_toolchain_root, root_build_dir) 35 rebase_path(android_toolchain_root, root_build_dir)
36 if (current_cpu == "arm" || current_cpu == "mipsel") { 36 if (current_cpu == "mipsel") {
hans 2015/12/01 15:18:24 Is the MIPS build gn only?
Nico 2015/12/01 15:21:37 No, gyp has something like this somewhere too.
37 cflags += [ 37 cflags += [
38 # TODO(hans) Enable integrated-as (crbug.com/124610). 38 # TODO(gordanac) Enable integrated-as.com/124610).
Johann 2015/12/01 15:26:18 Typo in the comment
Nico 2015/12/01 16:27:57 Done.
39 "-no-integrated-as", 39 "-no-integrated-as",
40 "-B${rebased_android_toolchain_root}/bin", # Else /usr/bin/as gets pick ed up. 40 "-B${rebased_android_toolchain_root}/bin", # Else /usr/bin/as gets pick ed up.
41 ] 41 ]
42 } 42 }
43 } 43 }
44 44
45 # Use gold for Android for most CPU architectures. 45 # Use gold for Android for most CPU architectures.
46 if (current_cpu == "x86" || current_cpu == "x64" || current_cpu == "arm") { 46 if (current_cpu == "x86" || current_cpu == "x64" || current_cpu == "arm") {
47 ldflags += [ "-fuse-ld=gold" ] 47 ldflags += [ "-fuse-ld=gold" ]
48 if (is_clang) { 48 if (is_clang) {
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 231
232 # Avoid errors with current NDK: 232 # Avoid errors with current NDK:
233 # "third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.6/prebui lt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.6/include/arm_neon.h:3426 :3: error: argument must be a constant" 233 # "third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.6/prebui lt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.6/include/arm_neon.h:3426 :3: error: argument must be a constant"
234 "-finstrument-functions-exclude-file-list=arm_neon.h,SaturatedArithmeticARM. h", 234 "-finstrument-functions-exclude-file-list=arm_neon.h,SaturatedArithmeticARM. h",
235 ] 235 ]
236 defines = [ "CYGPROFILE_INSTRUMENTATION=1" ] 236 defines = [ "CYGPROFILE_INSTRUMENTATION=1" ]
237 } 237 }
238 238
239 config("no_cygprofile_instrumentation") { 239 config("no_cygprofile_instrumentation") {
240 } 240 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698