Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1484643002: Make //device pass "gn check" (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make //device pass "gn check" Committed: https://crrev.com/bda835b5af97a7fce770017890354c00ca50f557 Cr-Commit-Position: refs/heads/master@{#363307}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M .gn View 1 chunk +1 line, -2 lines 0 comments Download
M build/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
M device/devices_app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/serial/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
M device/serial/serial_io_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/test/test_device_client.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M device/usb/usb_device_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/generate_library_loader/generate_library_loader.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484643002/1
5 years ago (2015-11-28 06:06:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484643002/20001
5 years ago (2015-11-28 06:15:57 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-11-28 06:15:58 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484643002/20001
5 years ago (2015-11-28 06:22:43 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/146463)
5 years ago (2015-11-28 06:38:08 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484643002/40001
5 years ago (2015-11-28 06:55:06 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-28 07:39:01 UTC) #14
brettw
5 years ago (2015-12-01 18:11:25 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484643002/40001
5 years ago (2015-12-01 18:12:28 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 19:11:05 UTC) #20
brettw
-> Scott, seems like Ken is out
5 years ago (2015-12-02 22:27:56 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484643002/40001
5 years ago (2015-12-04 21:12:18 UTC) #24
brettw
-> Dirk (Scott didn't feel familiar enough with some of this).
5 years ago (2015-12-04 21:14:02 UTC) #26
Dirk Pranke
lgtm
5 years ago (2015-12-04 21:18:42 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484643002/40001
5 years ago (2015-12-04 21:26:35 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-04 22:12:36 UTC) #31
commit-bot: I haz the power
5 years ago (2015-12-04 22:13:18 UTC) #33
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bda835b5af97a7fce770017890354c00ca50f557
Cr-Commit-Position: refs/heads/master@{#363307}

Powered by Google App Engine
This is Rietveld 408576698