Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: device/test/test_device_client.cc

Issue 1484643002: Make //device pass "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/serial_io_handler.cc ('k') | device/usb/usb_device_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/test/test_device_client.cc
diff --git a/device/test/test_device_client.cc b/device/test/test_device_client.cc
index f380c2cd04bcf6b83c72e009aab18a7ebf7ca2cb..ff6933ec04558a7cc6aaf3a7d7d5852c464ec415 100644
--- a/device/test/test_device_client.cc
+++ b/device/test/test_device_client.cc
@@ -4,8 +4,12 @@
#include "device/test/test_device_client.h"
-#include "device/hid/hid_service.h"
-#include "device/usb/usb_service.h"
+// This file unconditionally includes these headers despite conditionally
+// depending on the corresponding targets. The code below needs the destructors
+// of the classes defined even when the classes are never instantiated.
+// TODO: This should probably be done more explicitly to avoid ambiguity.
+#include "device/hid/hid_service.h" // nogncheck
+#include "device/usb/usb_service.h" // nogncheck
namespace device {
« no previous file with comments | « device/serial/serial_io_handler.cc ('k') | device/usb/usb_device_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698