chrome/browser/ui/sync/one_click_signin_sync_starter.cc - Issue 14846020: Add Views implementation of ProfileSigninConfirmationDialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 14846020: Add Views implementation of ProfileSigninConfirmationDialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: no ifdef on function proto Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/chromium_strings.grd ('K') | « chrome/browser/ui/browser_dialogs.h ('k') | chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h » ('j') | chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

index 5a5b99ebd0f20383fadd977a0872241f981bea13..dae78f050e9b204fa5404c607aac22e39c0de4c4 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

@@ -23,6 +23,7 @@

#include "chrome/browser/sync/profile_sync_service_factory.h"

#include "chrome/browser/sync/sync_prefs.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_dialogs.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_navigator.h"

#include "chrome/browser/ui/browser_window.h"

@@ -136,7 +137,7 @@ void OneClickSigninSyncStarter::OnRegisteredForPolicy(

policy_client_.swap(client);

// Allow user to create a new profile before continuing with sign-in.

- ProfileSigninConfirmationDialog::ShowDialog(

+ chrome::ShowProfileSigninConfirmationDialog(

profile_,

signin->GetUsernameForAuthInProgress(),

base::Bind(&OneClickSigninSyncStarter::CancelSigninAndDelete,