Add Views implementation of ProfileSigninConfirmationDialog.

chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h

Index: chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h
diff --git a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h
new file mode 100644
index 0000000000000000000000000000000000000000..3a758c7d21350c7eac74ec681091c8ba68f4fc02
--- /dev/null
+++ b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h
@@ -0,0 +1,92 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_SYNC_PROFILE_SIGNIN_CONFIRMATION_DIALOG_VIEWS_H_
+#define CHROME_BROWSER_UI_VIEWS_SYNC_PROFILE_SIGNIN_CONFIRMATION_DIALOG_VIEWS_H_
+
+#include "base/callback.h"
+#include "base/compiler_specific.h"
+#include "chrome/browser/ui/browser_dialogs.h"

[tfarina, 2013/05/07 18:16:18]

rm this include, if necessary, include in the source file.

[dconnelly, 2013/05/13 14:45:21]

Done.

+#include "ui/views/controls/link_listener.h"
+#include "ui/views/controls/styled_label_listener.h"
+#include "ui/views/window/dialog_delegate.h"
+
+class Profile;
+
+namespace content {

[tfarina, 2013/05/07 18:16:18]

also unused, remove.

[dconnelly, 2013/05/13 14:45:21]

Done.

+class WebContents;
+}
+
+namespace views {
+class TreeView;

[tfarina, 2013/05/07 18:16:18]

remove these unused forward declarations

[dconnelly, 2013/05/13 14:45:21]

Done.

+class Widget;
+}
+
+// A tab-modal dialog to allow a user signing in with a managed account
+// to create a new Chrome profile.
+class ProfileSigninConfirmationDialogViews : public views::DialogDelegateView,
+                                             public views::LinkListener,
+                                             public views::StyledLabelListener {
+ public:
+  // views::DialogDelegate:

[tfarina, 2013/05/07 18:16:18]

can all these overriddes be private?

[Andrew T Wilson (Slow), 2013/05/08 14:23:48]

No objection to moving these, but wanted to note for dconnelly's benefit that
the style guide says all inheritance should be public, and our last discussion
of this topic on chromium-dev resulted in the conclusion that either approach is
acceptable, at the discretion of the author.

That said, you could probably make your own private implementation of
DialogDelegateView inside the .cc file (since most of the functions don't
require access to this class) and hide the implementation entirely (use
composition instead of having this class implement DialogDelegateView).

[dconnelly, 2013/05/13 14:45:21]

If I'm doing that, is there any reason to not just hide the entire
implementation?  The only use of this class is through the single ShowDialog
function; there are no other clients.

+  virtual string16 GetWindowTitle() const OVERRIDE;
+  virtual int GetDialogButtons() const OVERRIDE;
+  virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
+  virtual views::View* CreateExtraView() OVERRIDE;
+  virtual void DeleteDelegate() OVERRIDE;
+  virtual bool Accept() OVERRIDE;
+  virtual bool Cancel() OVERRIDE;
+  virtual void OnClose() OVERRIDE;
+  virtual ui::ModalType GetModalType() const OVERRIDE;
+
+  // views::LinkListener:
+  virtual void LinkClicked(views::Link* source, int event_flags) OVERRIDE;
+
+  // views::StyledLabelListener:
+  virtual void StyledLabelLinkClicked(const ui::Range& range,
+                                      int event_flags) OVERRIDE;
+
+ private:
+  friend void chrome::ShowProfileSigninConfirmationDialog(
+      Profile*, const std::string&,
+      const base::Closure&, const base::Closure&, const base::Closure&);
+
+  ProfileSigninConfirmationDialogViews(
+      Profile* profile,
+      const std::string& username,
+      const base::Closure& cancel_signin,
+      const base::Closure& signin_with_new_profile,
+      const base::Closure& continue_signin);
+  virtual ~ProfileSigninConfirmationDialogViews();
+
+  // Shows the dialog and releases ownership of this object. It will
+  // delete itself when the dialog is closed. If |prompt_for_new_profile|
+  // is true, the dialog will offer to create a new profile before signin.
+  void Show(bool prompt_for_new_profile);
+
+  // Weak ptr to parent view.
+  gfx::NativeWindow window_;
+
+  // The profile being signed in.
+  Profile* profile_;
+
+  // The GAIA username being signed in.
+  std::string username_;
+
+  // Whether to show the "Create a new profile" button.
+  bool prompt_for_new_profile_;
+
+  // Dialog button callbacks.
+  bool responded;

[tfarina, 2013/05/07 18:16:18]

s/responded/responded_

Could you name it better though?

[dconnelly, 2013/05/13 14:45:21]

Removed.

+  base::Closure cancel_signin_;
+  base::Closure signin_with_new_profile_;
+  base::Closure continue_signin_;
+
+  // The link to create a new profile.
+  views::Link* link_;
+
+  DISALLOW_COPY_AND_ASSIGN(ProfileSigninConfirmationDialogViews);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_SYNC_PROFILE_SIGNIN_CONFIRMATION_DIALOG_VIEWS_H_