Add Views implementation of ProfileSigninConfirmationDialog.

chrome/browser/ui/sync/profile_signin_confirmation_helper.h

Index: chrome/browser/ui/sync/profile_signin_confirmation_helper.h
diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper.h b/chrome/browser/ui/sync/profile_signin_confirmation_helper.h
index 36ad62a3f488da99485cc8605d351f6aaef25c08..aaf7d317ea5eef2b688321821aa1bd3c0c1a39fe 100644
--- a/chrome/browser/ui/sync/profile_signin_confirmation_helper.h
+++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper.h
@@ -15,11 +15,18 @@ namespace ui {
 // profile was created.
 bool HasBeenShutdown(Profile* profile);
 
+// Indicates whether the user should be prompted to create a new
+// profile before signin.
+enum DisplayCreateProfilePrompt {
+  PROMPT_TO_CREATE_PROFILE,
+  DO_NOT_PROMPT_TO_CREATE_PROFILE
+};
+
 // Determines whether the user should be prompted to create a new
 // profile before signin.
 void CheckShouldPromptForNewProfile(
     Profile* profile,
-    const base::Callback<void(bool)>& cb);
+    const base::Callback<void(DisplayCreateProfilePrompt)>& cb);

[Peter Kasting, 2013/05/15 00:11:03]

Nit: Personally I slightly prefer the old bool, since the function name makes it
pretty clear what it means (and you can add an explicit comment if you think
that's not enough).

I'm more in favor of using enums in place of bools when e.g. there are multiple
bool args in a row so it's easy to accidentally swap them without the compile
catching you, or when it's impossible to name/comment things sufficiently
clearly.

[Andrew T Wilson (Slow), 2013/05/16 08:00:30]

Peter has a reasonable point - if you also prefer the old bool, I have no
objections either way.

[dconnelly, 2013/05/17 13:01:55]

Done.

 
 }  // namespace ui