Add Views implementation of ProfileSigninConfirmationDialog.

chrome/browser/ui/sync/profile_signin_confirmation_helper.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_SYNC_PROFILE_SIGNIN_CONFIRMATION_HELPER_H_
 #define CHROME_BROWSER_UI_SYNC_PROFILE_SIGNIN_CONFIRMATION_HELPER_H_
 
 #include "base/callback.h"
 
 class Profile;
 
 namespace ui {
 
 // Determines whether the browser has ever been shutdown since the
 // profile was created.
 bool HasBeenShutdown(Profile* profile);
 
+// Indicates whether the user should be prompted to create a new
+// profile before signin.
+enum DisplayCreateProfilePrompt {
+  PROMPT_TO_CREATE_PROFILE,
+  DO_NOT_PROMPT_TO_CREATE_PROFILE
+};
+
 // Determines whether the user should be prompted to create a new
 // profile before signin.
 void CheckShouldPromptForNewProfile(
     Profile* profile,
-    const base::Callback<void(bool)>& cb);
+    const base::Callback<void(DisplayCreateProfilePrompt)>& cb);

[Peter Kasting, 2013/05/15 00:11:03]

Nit: Personally I slightly prefer the old bool, since the function name makes it
pretty clear what it means (and you can add an explicit comment if you think
that's not enough).

I'm more in favor of using enums in place of bools when e.g. there are multiple
bool args in a row so it's easy to accidentally swap them without the compile
catching you, or when it's impossible to name/comment things sufficiently
clearly.

[Andrew T Wilson (Slow), 2013/05/16 08:00:30]

Peter has a reasonable point - if you also prefer the old bool, I have no
objections either way.

[dconnelly, 2013/05/17 13:01:55]

Done.

 
 }  // namespace ui
 
 #endif  // CHROME_BROWSER_UI_SYNC_PROFILE_SIGNIN_CONFIRMATION_HELPER_H_