components/mus/ws/window_tree_impl.h - Issue 1484533002: mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/ws/window_tree_impl.h

Issue 1484533002: mus: Introduce AttachSurface to allow creating Surface prior to OnEmbed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ThreadChecker Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/mus/public/interfaces/window_tree.mojom ('K') | « components/mus/public/interfaces/window_tree.mojom ('k') | components/mus/ws/window_tree_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/ws/window_tree_impl.h

diff --git a/components/mus/ws/window_tree_impl.h b/components/mus/ws/window_tree_impl.h

index babe1d7c3eea264a31b66df216c249db0f0ecb95..0f7d9b9a89b2deb5984e7276e42783dc1927558d 100644

--- a/components/mus/ws/window_tree_impl.h

+++ b/components/mus/ws/window_tree_impl.h

@@ -226,10 +226,10 @@ class WindowTreeImpl : public mojom::WindowTree, public AccessPolicyDelegate {

Id window_id,

const mojo::String& name,

mojo::Array<uint8_t> value) override;

- void RequestSurface(Id window_id,

- mojom::SurfaceType type,

- mojo::InterfaceRequest<mojom::Surface> surface,

- mojom::SurfaceClientPtr client) override;

+ void AttachToSurface(Id window_id,

+ mojom::SurfaceType type,

+ mojo::InterfaceRequest<mojom::Surface> surface,

+ mojom::SurfaceClientPtr client) override;

void Embed(Id transport_window_id,

mojom::WindowTreeClientPtr client,

uint32_t policy_bitmask,