content/common/input/synthetic_web_input_event_builders.cc - Issue 148453012: Chrome requires WebTouchPoint to store WebFloatPoint, instead of WebPoint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/input/synthetic_web_input_event_builders.cc

Issue 148453012: Chrome requires WebTouchPoint to store WebFloatPoint, instead of WebPoint. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removing ugly floating point error fix Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/input/touch_event_queue.cc ('K') | « content/common/input/synthetic_web_input_event_builders.h ('k') | content/renderer/input/input_handler_proxy.cc » ('j') | content/renderer/input/input_handler_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/input/synthetic_web_input_event_builders.cc

diff --git a/content/common/input/synthetic_web_input_event_builders.cc b/content/common/input/synthetic_web_input_event_builders.cc

index e2c29bfbe78b5a9bf7bacc2855b37ac13109e539..f5a8aa3f212d56e09cdc7fbae8a3127a1c90ee5d 100644

--- a/content/common/input/synthetic_web_input_event_builders.cc

+++ b/content/common/input/synthetic_web_input_event_builders.cc

@@ -159,7 +159,7 @@ void SyntheticWebTouchEvent::ResetPoints() {

type = WebInputEvent::Undefined;

}

-int SyntheticWebTouchEvent::PressPoint(int x, int y) {

+int SyntheticWebTouchEvent::PressPoint(float x, float y) {

if (touchesLength == touchesLengthCap)

return -1;

WebTouchPoint& point = touches[touchesLength];

@@ -173,7 +173,7 @@ int SyntheticWebTouchEvent::PressPoint(int x, int y) {

return point.id;

}

-void SyntheticWebTouchEvent::MovePoint(int index, int x, int y) {

+void SyntheticWebTouchEvent::MovePoint(int index, float x, float y) {

CHECK(index >= 0 && index < touchesLengthCap);

WebTouchPoint& point = touches[index];

point.position.x = point.screenPosition.x = x;