Support VS2013 Express for automatic toolchain too

Support VS2013 Express for automatic toolchain too

And for now, defaults to Express.

Main changes:
- Valid hash becomes a set of hashes one for Pro, one for Express
- Include WDK to get an old copy of ATL as that doesn't come
  with Express

BUG=323300
R=maruel@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248622

[M-A Ruel, 2014-02-03 23:10:52]

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/get_toolc...
File win_toolchain/get_toolchain_if_necessary.py (right):

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/get_toolc...
win_toolchain/get_toolchain_if_necessary.py:129: # pull and use that as a signal
to install Pro also.
I don't think this is a useful signal at all.

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/get_toolc...
win_toolchain/get_toolchain_if_necessary.py:130: should_get_pro =
os.path.isfile(os.path.join(BASEDIR, '.vspro'))
Who creates this file?

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/toolchain...
File win_toolchain/toolchain2013.py (right):

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/toolchain...
win_toolchain/toolchain2013.py:215: if os.environ.get('CHROME_HEADLESS'):
I'd prefer an option --bot-mode with
default=bool(int(os.environ.get('CHROME_HEADLESS', 0))) and pass this value down
here.

[scottmg, 2014-02-03 23:22:11]

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/get_toolc...
File win_toolchain/get_toolchain_if_necessary.py (right):

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/get_toolc...
win_toolchain/get_toolchain_if_necessary.py:129: # pull and use that as a signal
to install Pro also.
On 2014/02/03 23:10:52, M-A Ruel wrote:
> I don't think this is a useful signal at all.

Why? src-internal doesn't correspond to Googler corresponding to site license of
VS?

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/get_toolc...
win_toolchain/get_toolchain_if_necessary.py:130: should_get_pro =
os.path.isfile(os.path.join(BASEDIR, '.vspro'))
On 2014/02/03 23:10:52, M-A Ruel wrote:
> Who creates this file?

User-created, if they have a 2013 license.

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/toolchain...
File win_toolchain/toolchain2013.py (right):

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/toolchain...
win_toolchain/toolchain2013.py:215: if os.environ.get('CHROME_HEADLESS'):
On 2014/02/03 23:10:52, M-A Ruel wrote:
> I'd prefer an option --bot-mode with
> default=bool(int(os.environ.get('CHROME_HEADLESS', 0))) and pass this value
down
> here.

Done.

[M-A Ruel, 2014-02-03 23:41:44]

lgtm

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/get_toolc...
File win_toolchain/get_toolchain_if_necessary.py (right):

https://codereview.chromium.org/148453008/diff/100001/win_toolchain/get_toolc...
win_toolchain/get_toolchain_if_necessary.py:129: # pull and use that as a signal
to install Pro also.
On 2014/02/03 23:22:12, scottmg wrote:
> On 2014/02/03 23:10:52, M-A Ruel wrote:
> > I don't think this is a useful signal at all.
> 
> Why? src-internal doesn't correspond to Googler corresponding to site license
of
> VS?

I mean, non googlers could have license too. But non googlers can fix this if
they care about it. :)

[scottmg, 2014-02-04 00:00:48]

On 2014/02/03 23:41:44, M-A Ruel wrote:
> lgtm
> 
>
https://codereview.chromium.org/148453008/diff/100001/win_toolchain/get_toolc...
> File win_toolchain/get_toolchain_if_necessary.py (right):
> 
>
https://codereview.chromium.org/148453008/diff/100001/win_toolchain/get_toolc...
> win_toolchain/get_toolchain_if_necessary.py:129: # pull and use that as a
signal
> to install Pro also.
> On 2014/02/03 23:22:12, scottmg wrote:
> > On 2014/02/03 23:10:52, M-A Ruel wrote:
> > > I don't think this is a useful signal at all.
> > 
> > Why? src-internal doesn't correspond to Googler corresponding to site
license
> of
> > VS?
> 
> I mean, non googlers could have license too. But non googlers can fix this if
> they care about it. :)

Ah, I see. Yes, I intended that to be or'd with the .vspro file test at a
minimum (which I'll send shortly :).

[scottmg, 2014-02-04 00:00:52]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-02-04 00:01:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/148453008/170001

[commit-bot: I haz the power, 2014-02-04 00:01:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 00:01:02]

Failed to apply patch for depot_tools/win_toolchain/toolchain_vs2013.hash:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file depot_tools/win_toolchain/toolchain_vs2013.hash
  Hunk #1 FAILED at 1.
  1 out of 1 hunk FAILED -- saving rejects to file
depot_tools/win_toolchain/toolchain_vs2013.hash.rej

Patch:       depot_tools/win_toolchain/toolchain_vs2013.hash
Index: win_toolchain/toolchain_vs2013.hash
diff --git depot_tools/win_toolchain/toolchain_vs2013.hash
depot_tools/win_toolchain/toolchain_vs2013.hash
index
68d0f24c1ec762d6640da2a3b08094feba281302..d6b0bee36b6f9c005478b4f6f0977c130adc44f4
100644
--- a/depot_tools/win_toolchain/toolchain_vs2013.hash
+++ b/depot_tools/win_toolchain/toolchain_vs2013.hash
@@ -1 +1,2 @@
-f8cf785f85a00d98b52b3614b52cae3f544b1143
+627d3dc8e237717ceed024554fede5f41522f5e6
+1dd80dff1c6b2fc79b586c7d3df303ad68426f58

[commit-bot: I haz the power, 2014-02-04 00:01:10]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-04 00:01:11]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-04 00:01:11]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-04 00:01:11]

CQ bit was unchecked on CL. Ignoring.

[scottmg, 2014-02-04 00:07:08]

Committed patchset #6 manually as r248622 (presubmit successful).