Support VS2013 Express for automatic toolchain too

win_toolchain/get_toolchain_if_necessary.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Downloads and unpacks a toolchain for building on Windows. The contents are
 matched by sha1 which will be updated when the toolchain is updated.
 
 Having a toolchain script in depot_tools means that it's not versioned
 directly with the source code. That is, if the toolchain is upgraded, but
@@ skipping 85 matching lines @@
 
   digest = hashlib.sha1()
   for path in file_list:
     digest.update(path)
     with open(path, 'rb') as f:
       digest.update(f.read())
   return digest.hexdigest()
 
 
 def SaveTimestampsAndHash(root, sha1):
-  """Save timestamps and the final hash to be able to early-out more quickly
+  """Saves timestamps and the final hash to be able to early-out more quickly
   next time."""
   file_list = GetFileList(root)
   timestamps_data = {
     'files': [[f, os.stat(f).st_mtime] for f in file_list],
     'sha1': sha1,
   }
   with open(MakeTimestampsFileName(root), 'wb') as f:
     json.dump(timestamps_data, f)
 
 
 def main():
   if not sys.platform.startswith(('cygwin', 'win32')):
     return 0
 
   if len(sys.argv) != 1:
     print >> sys.stderr, 'Unexpected arguments.'
     return 1
 
   # Move to depot_tools\win_toolchain where we'll store our files, and where
   # the downloader script is.
   os.chdir(os.path.normpath(os.path.join(BASEDIR)))
+  # TODO(scottmg): http://crbug.com/323300 Attempt to locate a src-internal
+  # pull and use that as a signal to install Pro also.

[M-A Ruel, 2014/02/03 23:10:52]

I don't think this is a useful signal at all.

[scottmg, 2014/02/03 23:22:12]

Why? src-internal doesn't correspond to Googler corresponding to site license of
VS?

[M-A Ruel, 2014/02/03 23:41:44]

I mean, non googlers could have license too. But non googlers can fix this if
they care about it. :)

+  should_get_pro = os.path.isfile(os.path.join(BASEDIR, '.vspro'))

[M-A Ruel, 2014/02/03 23:10:52]

Who creates this file?

[scottmg, 2014/02/03 23:22:12]

User-created, if they have a 2013 license.

   toolchain_dir = '.'
   target_dir = os.path.normpath(os.path.join(toolchain_dir, 'vs2013_files'))
 
   sha1path = os.path.join(toolchain_dir, 'toolchain_vs2013.hash')
-  desired_hash = ''
+  desired_hashes = set()
   if os.path.isfile(sha1path):
     with open(sha1path, 'rb') as f:
-      desired_hash = f.read().strip()
+      desired_hashes = set(f.read().strip().splitlines())
 
   # If the current hash doesn't match what we want in the file, nuke and pave.
   # Typically this script is only run when the .sha1 one file is updated, but
   # directly calling "gclient runhooks" will also run it, so we cache
   # based on timestamps to make that case fast.
   current_hash = CalculateHash(target_dir)
-  if current_hash != desired_hash:
-    print 'Windows toolchain out of date or doesn\'t exist, updating...'
+  if current_hash not in desired_hashes:
+    print('Windows toolchain out of date or doesn\'t exist, updating (%s)...' %
+          ('Pro' if should_get_pro else 'Express'))
     # This stays resident and will make the rmdir below fail.
     subprocess.call(['taskkill', '/f', '/im', 'mspdbsrv.exe'])
     if os.path.isdir(target_dir):
       subprocess.check_call('rmdir /s/q "%s"' % target_dir, shell=True)
-    subprocess.check_call([
-        sys.executable,
-        'toolchain2013.py',
-        '--targetdir', target_dir])
+    args = [sys.executable,
+            'toolchain2013.py',
+            '--targetdir', target_dir]
+    if not should_get_pro:
+      args.append('--express')
+    subprocess.check_call(args)
     current_hash = CalculateHash(target_dir)
-    if current_hash != desired_hash:
+    if current_hash not in desired_hashes:
       print >> sys.stderr, (
           'Got wrong hash after pulling a new toolchain. '
-          'Wanted \'%s\', got \'%s\'.' % (
-              desired_hash, current_hash))
+          'Wanted one of \'%s\', got \'%s\'.' % (
+              desired_hashes, current_hash))
       return 1
     SaveTimestampsAndHash(target_dir, current_hash)
 
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())