Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1484473002: Fix Reflect.construct wrt proxy, generator, and non-subclass new.target (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
Igor Sheludko, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Reflect.construct wrt proxy, generator, and non-subclass new.target This makes sure that proxy + Function/Array works Makes sure that new.target can be a generator Makes sure that if new.target is not a subclass, but does not have a prototype, that we'll get that same prototype back the next time we look at new.target.prototype. BUG=v8:1543, v8:3330, v8:3931 LOG=n Committed: https://crrev.com/970a7ad7583c0270b86e602331a24e7cdfdadc8e Cr-Commit-Position: refs/heads/master@{#32382}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -100 lines) Patch
M src/objects.h View 1 1 chunk +7 lines, -5 lines 0 comments Download
M src/objects.cc View 1 2 3 4 4 chunks +72 lines, -35 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 1 chunk +9 lines, -8 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 1 chunk +4 lines, -42 lines 0 comments Download
M test/mjsunit/es6/classes-proxy.js View 1 chunk +32 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/reflect-construct.js View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Toon Verwaest
ptal
5 years ago (2015-11-27 17:16:14 UTC) #3
Igor Sheludko
lgtm
5 years ago (2015-11-27 20:58:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484473002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484473002/70001
5 years ago (2015-11-27 20:58:49 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years ago (2015-11-27 21:44:33 UTC) #8
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/970a7ad7583c0270b86e602331a24e7cdfdadc8e Cr-Commit-Position: refs/heads/master@{#32382}
5 years ago (2015-11-27 21:44:56 UTC) #10
adamk
Note that generators no longer have a [[Construct]] slot (https://github.com/tc39/ecma262/commit/bddde2330989a5a8daf26b37963f668bb3382371), so that part of this ...
5 years ago (2015-11-30 21:56:48 UTC) #12
Toon Verwaest
5 years ago (2015-12-01 15:34:22 UTC) #13
Message was sent while issue was closed.
I noticed it was wrong anyway. It doesn't use new.target but F instead, for some
reason.

Powered by Google App Engine
This is Rietveld 408576698