Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: test/mjsunit/es6/classes-proxy.js

Issue 1484473002: Fix Reflect.construct wrt proxy, generator, and non-subclass new.target (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-object.cc ('k') | test/mjsunit/harmony/reflect-construct.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/es6/classes-proxy.js
diff --git a/test/mjsunit/es6/classes-proxy.js b/test/mjsunit/es6/classes-proxy.js
index 1a31cf7c12b2f55e6305452725854e8039223d23..d438b01ad8a3a5022f12084c695b39f4193e5f96 100644
--- a/test/mjsunit/es6/classes-proxy.js
+++ b/test/mjsunit/es6/classes-proxy.js
@@ -39,3 +39,35 @@ function CreateConstructableProxy(handler) {
assertTrue(Object.getPrototypeOf(o) === Object.prototype);
assertEquals(100, Number.prototype.valueOf.call(o));
})();
+
+(function() {
+ var prototype = { x: 1 };
+ var log = [];
+
+ var proxy = CreateConstructableProxy({
+ get(k) {
+ log.push("get trap");
+ return prototype;
+ }});
+
+ var o = Reflect.construct(Function, ["return 1000"], proxy);
+ assertEquals(["get trap"], log);
+ assertTrue(Object.getPrototypeOf(o) === prototype);
+ assertEquals(1000, o());
+})();
+
+(function() {
+ var prototype = { x: 1 };
+ var log = [];
+
+ var proxy = CreateConstructableProxy({
+ get(k) {
+ log.push("get trap");
+ return prototype;
+ }});
+
+ var o = Reflect.construct(Array, [1, 2, 3], proxy);
+ assertEquals(["get trap"], log);
+ assertTrue(Object.getPrototypeOf(o) === prototype);
+ assertEquals([1, 2, 3], o);
+})();
« no previous file with comments | « src/runtime/runtime-object.cc ('k') | test/mjsunit/harmony/reflect-construct.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698